[pkg-php-pear] Bug#820420: ITP: php7cc -- command line tool to detect PHP 7 incompatible code
Mathieu Parent
math.parent at gmail.com
Fri Apr 8 14:32:20 UTC 2016
2016-04-08 10:10 GMT+02:00 Dmitry Smirnov <onlyjob at debian.org>:
> Dear PHP team,
>
> I've packaged "php7cc" (PHP 7 Compatibility Checker) utility that (I hope)
> will be useful to help massive transition to PHP-7.
>
> Package is ready for upload to "experimental" but before upload I'd
> appreciate a brief review and permission to maintain it here.
Everything looks good. Some notes:
- your gbp.conf is not our current workflow. Are you ok to match it?
- Why are you using dh-exec for d/install?
- pkg-php-tools-overrides: There is also depends.patch. Which one is
correct? If the override is correct, please report to the
pkg-php-tools package.
-d/watch. version=4 ?!
- shebang.patch: SHould probably be forwarded
Some nitpicking:
- in control file: use wrap-and-sort to remove the commas at line start.
Regards
--
Mathieu
More information about the pkg-php-pear
mailing list