[pkg-php-pear] Bug#820420: ITP: php7cc -- command line tool to detect PHP 7 incompatible code
onlyjob at debian.org
Fri Apr 8 22:55:40 UTC 2016
Thanks for your time, Mathieu.
On Friday, 8 April 2016 4:32:20 PM AEST Mathieu Parent wrote:
> - your gbp.conf is not our current workflow. Are you ok to match it?
This is quite confusing. Although http://php.debian.net/ suggests using
"debian-sid" and "upstream-sid" branches I've noticed that all packages that
I checked use traditional GBP layout that I'm certainly more comfortable with
because it is commonly used by other teams.
I had a look at the following packages/repositories:
php-codesniffer (mixed layout, recent updates in master)
php-timer (mixed layout, recent updates in master)
None of those packages even have "gbp.conf" so I got impression that layout
isnformation either outdated or not strictly followed...
Apart from that I've already made an effort to match GBP workflow as
personally I prefer un-merged (debian only) "master" branches and (when
applicable) no "upstream" branch at all.
> - Why are you using dh-exec for d/install?
Because it is an elegant way to rename file on install without using DH
overrides in rules. Could be done differently though, without dh-exec...
> - pkg-php-tools-overrides: There is also depends.patch. Which one is
> correct? If the override is correct, please report to the
> pkg-php-tools package.
Thanks. I've learned about pkg-php-tools-overrides after I crafted
"depends.patch". They are both correct but now after introducing pkg-php-
tools-overrides renaming module in "depends.patch" is no longer necessary.
Unfortunately patch is still required because it is also correcting version.
> -d/watch. version=4 ?!
Yes. :) What about it??
> - shebang.patch: SHould probably be forwarded
Maybe eventually... Upstream seems to deliberately install "php7cc" wrapper
with shebang and "require php7cc.php". I add sheband to "php7cc.php" and
install it as "php7cc". I feel that our way is better but there may be
reasons for upstream to do what he did and right now I have neither energy
nor time to discuss this matter with upstream.
> Some nitpicking:
> - in control file: use wrap-and-sort to remove the commas at line start.
Thanks. I know about "wrap-and-sort" but I don't use it. I just hate it. :)
In more sophisticated packages it is not helpful because it eliminates
comments and even drop legitimate information in some cases (there were some
bugs about it still open last time I checked). Also "wrap-and-sort" drop
meaningful padding (if any) and mess logical order of dependencies. For
example in "control" file I may have something like
Often I find such hints useful to know which dependencies are required by
As for leading commas, I like that style. It helps to produce clean diffs
when dependencies change.
The Santa myth is one of the most effective means ever devised for
intimidating children, eroding their self-esteem, twisting their
behavior, warping their values, and slowing their development of
critical thinking skills.
-- Tom Flynn, "The Trouble with Christmas"
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 819 bytes
Desc: This is a digitally signed message part.
More information about the pkg-php-pear