[pkg-php-pear] php-net-idna2 -- PHP library for handling international domain names (reviewed)

[Paul Wise]

On Sun, 2016-10-09 at 19:28 +0530, Rajasekhar Ponakala wrote:

> Thanks for reviewing the package, we've made changes regarding your
> review. The following is the log.

Great, hopefully someone on the team can sponsor you, I'm not
knowledgeable about PHP.

> Lintain complains if pear package does not contain Recommends and Breaks
> fields.

Probably the tool that generates the phppear:* fields should generate
them empty when they are not applicable, instead of deleting them.
The current situation of lintian saying one thing and dpkg-gencontrol
saying another thing is really quite confusing.

> Upstream summary and description as not of sufficient quality.

Personally I would have patched the upstream summary and still used the
fields instead of hardcoding a Debian-specific description in
debian/control. Then you could send the patch upstream too.

> Created an upstream bug requesting the author to sign:
> https://pear.php.net/bugs/bug.php?id=21123

You may want to point them at the OpenPGP best practices:

https://help.riseup.net/en/security/message-security/openpgp/best-practices
https://mikegerwitz.com/papers/git-horror-story

> Raised a pull request: https://github.com/pear/Net_IDNA2/pull/2

While looking at that patch, I saw one more typo:

Apllies

> Raised a pull request changing http to https wherever possible:
> https://github.com/pear/Net_IDNA2/pull/2

Looks like you changed the URLs to DTDs, that has broken things
according to Travis, never blindly change all URLs to https.

> Raised an upstream pull request: https://github.com/pear/Net_IDNA2/pull/2

I'd really suggest not mixing completely different issues in the same
pull request. Also, you didn't send a patch for that issue.

-- 
bye,
pabs

https://wiki.debian.org/PaulWise
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: This is a digitally signed message part
URL: <http://lists.alioth.debian.org/pipermail/pkg-php-pear/attachments/20161010/3e416d31/attachment.sig>