[pkg-php-pear] php-net-idna2 -- PHP library for handling international domain names (reviewed)

[Rajasekhar Ponakala]

Hi PaulWise,

Thanks for reviewing the package, we've made changes regarding your
review. The following is the log.


> Usually DH_VERBOSE is commented out in debian/rules

DH_VERBOSE has been commented out

> Please use https for the Homepage link

Done.

> I suggest running this command, makes debian/ diffs easier to read:

Done.

> wrap-and-sort --short-indent --wrap-always --sort-binary-packages
--trailing-comma

Done.

> Please add some upstream metadata:
> https://wiki.debian.org/UpstreamMetadata

Done.

> Upstream might want to sign their releases so that Debian can verify them:
> https://wiki.debian.org/debian/watch#Cryptographic_signature_verification

Request raised: https://pear.php.net/bugs/bug.php?id=21123

> Automatic checks:
>
> build:
> dpkg-gencontrol: warning: Recommends field of package php-net-idna2:
unknown substitution variable ${phppear:Debian-Recommends}
> dpkg-gencontrol: warning: Breaks field of package php-net-idna2:
unknown substitution variable ${phppear:Debian-Breaks}

Lintain complains if pear package does not contain Recommends and Breaks
fields.

> dpkg-gencontrol: warning: package php-net-idna2: unused substitution
variable ${phppear:description}
> dpkg-gencontrol: warning: package php-net-idna2: unused substitution
variable ${phppear:summary}
> dpkg-gencontrol: warning: package php-net-idna2: unused substitution
variable ${phppear:channel}

Upstream summary and description as not of sufficient quality.

> lintian:
> I: php-net-idna2 source: pear-package-not-using-substvar
${phppear:summary}
> I: php-net-idna2 source: pear-package-not-using-substvar
${phppear:description}

Upstream summary and description as not of sufficient quality.

> P: php-net-idna2 source: debian-watch-may-check-gpg-signature

Created an upstream bug requesting the author to sign:
https://pear.php.net/bugs/bug.php?id=21123

> check-all-the-things:
>
> $ codespell --quiet-level=3
> ./Net_IDNA2-0.1.1/Net/IDNA2.php:2681: occurence  ==> occurrence
> ./Net_IDNA2-0.1.1/Net/IDNA2.php:2799: cannonical  ==> canonical
> ./Net_IDNA2-0.1.1/Net/IDNA2.php:2991: cannonical  ==> canonical

Raised a pull request: https://github.com/pear/Net_IDNA2/pull/2

> # check if these can be switched to https://
> $ grep -rF http: .
> <a bunch>

Raised a pull request changing http to https wherever possible:
https://github.com/pear/Net_IDNA2/pull/2

> $ licensecheck --check=. --recursive --copyright . | grep --text -F
'with incorrect FSF address'
> ./Net_IDNA2-0.1.1/Net/IDNA2.php: *No copyright* LGPL (v2.1 or later)
(with incorrect FSF address)

Raised an upstream pull request: https://github.com/pear/Net_IDNA2/pull/2


> $ find -type d \( -iname .bzr -o -iname .git -o -iname .hg -o -iname
.svn -o -iname CVS -o -iname RCS -o -iname SCCS -o -iname _MTN -o -iname
_darcs -o -iname .pc -o -iname .cabal-sandbox -o -iname .cdv -o -iname
.metadata -o -iname CMakeFiles -o -iname _build -o -iname _sgbak -o
-iname autom4te.cache -o -iname blib -o -iname cover_db -o -iname
node_modules -o -iname '~.dep' -o -iname '~.dot' -o -iname '~.nib' -o
-iname '~.plst' \) -prune -o -type f ! \( -iname '*.bak' -o -iname
'*.swp' -o -iname '#.*' -o -iname '#*#' -o -iname 'core.*' -o -iname
'*~' -o -iname '*.gif' -o -iname '*.jpg' -o -iname '*.jpeg' -o -iname
'*.png' -o -iname '*.min.js' -o -iname '*.js.map' -o -iname '*.js.min'
-o -iname '*.min.css' -o -iname '*.css.map' -o -iname '*.css.min' -o
-iname '*.wav' \) -exec env PERL5OPT=-m-lib=. spellintian --picky {} +
> ./Net_IDNA2-0.1.1/Net/IDNA2.php: wether -> whether
> ./Net_IDNA2-0.1.1/Net/IDNA2.php: occurence -> occurrence
> ./Net_IDNA2-0.1.1/Net/IDNA2.php: stirng -> string
> ./Net_IDNA2-0.1.1/Net/IDNA2.php: paramaters -> parameters
> ./Net_IDNA2-0.1.1/Net/IDNA2.php: allows to -> allows one to

Raised a pull request: https://github.com/pear/Net_IDNA2/pull/2


Regards-
     --Rajasekhar [Hacktivist @swecha]



-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0x09E58EB8.asc
Type: application/pgp-keys
Size: 13209 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-php-pear/attachments/20161009/2024293b/attachment.key>