[pkg-php-pear] RFS: php-netscape-bookmark-parser

James Valleroy jvalleroy at mailbox.org
Wed Oct 30 00:55:52 GMT 2019

Hi David,

Thanks for the review.

On 10/15/19 12:14 PM, David Prévot wrote:
> [ I explicitly CCed you in case you don’t yet receive the mailing list,
>   feel free to tell me that you do and I’ll stop ;). ]

I'm subscribed to the mailing list now.

> Here is a quick review (feel free to ask for more information if my
> advice is not clear), I haven’t yet built or tested the package (but
> it’s small enough so that shouldn’t take too long once you’ve addressed
> the autoload.php concerns).

I made the following changes:
- Used a template for autoload.php so it loads its dependency.
- Added debian/clean.
- Rebased the repository to upstream. I used "git deborig" to produce
the orig tarball, and imported it.
- Switched to running upstream tests in autopkgtest. Patches the tests
to run on current phpunit.

Does this look ok?


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://alioth-lists.debian.net/pipermail/pkg-php-pear/attachments/20191029/9e29982d/attachment.sig>

More information about the pkg-php-pear mailing list