[pkg-php-pear] RFS: php-netscape-bookmark-parser

[David Prévot]

Hi,

Le 31/10/2019 à 13:15, James Valleroy a écrit :
> On 10/29/19 9:50 PM, David Prévot wrote:

> NetscapeBookmarkParser by
> default writes logs to the directory where NetscapeBookmarkParser.php is
> located:
> 
> $logDir == null ? __DIR__ . '/logs/' : $logDir,

That’s ugly, glad you caught that (another yay for tests ;).

> So it tries to create log files in
> /usr/share/php/Shaarli/NetscapeBookmarkParser/logs/. I am considering to
> patch this line to remove the __DIR__, so that logs are written to the
> current working directory (unless otherwise specified). Does this sound ok?

That seems like an improvement, thanks. Using a proper /var/log path and
handling rights correctly may be overkill and messy. Using a tempdir
might also be OK: more work, but maybe more robust if called from a
system path without the proper $logDir set.

You could propose your patches upstream: they may want to move to a more
recent PHPUnit at some point, and handle more properly their default
$logDir (or at least, have an opinion about it).

Regards

David

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://alioth-lists.debian.net/pipermail/pkg-php-pear/attachments/20191031/bdc7e849/attachment.sig>