[pkg-php-pear] RFS: php-netscape-bookmark-parser
jvalleroy at mailbox.org
Thu Oct 31 23:15:15 GMT 2019
On 10/29/19 9:50 PM, David Prévot wrote:
> - You should not use needs-root for autopkgtest (and definitely not
> write a cache file under /usr/bin/). You may use the phpunit
> --do-not-cache-result or --cache-result-file=<file> options instead
> (do not forget to clean up the cache file if you use it).
> - The autopkgtest should test the *installed* files.
I can use --do-not-cache-result, but there is one more issue when I
remove needs-root and test the installed file. NetscapeBookmarkParser by
default writes logs to the directory where NetscapeBookmarkParser.php is
$logDir == null ? __DIR__ . '/logs/' : $logDir,
So it tries to create log files in
/usr/share/php/Shaarli/NetscapeBookmarkParser/logs/. I am considering to
patch this line to remove the __DIR__, so that logs are written to the
current working directory (unless otherwise specified). Does this sound ok?
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 833 bytes
Desc: OpenPGP digital signature
More information about the pkg-php-pear