[pkg-php-pear] RFS: php-gettext-languages

[James Valleroy]

Hi David,

On 8/23/20 11:10 AM, David Prévot wrote:
> I believe there is a typo on the source package name (missing final “s” in debian/control and debian/changelog), so I didn’t uploaded it (yet). I noted a few other things that you may wish to look into (but I’m fine uploading it as is for NEW processing):

Thanks for catching this, it was definitely a mistake. I added the "s" in both files.

> - debian/clean is missing a final slash at the end of the first line;

Added, and I tested the clean step as well.

> - bin/export-plural-rules should be patched to find the autoloader.php where it is installed, and could probably be installed in usr/bin (or the php-cli dependency should probably be dropped);

I removed the php-cli dependency. The script is only installed as an example for now.

> - probably not worth the headache, but cldr-data could be installed in /usr/share/php/data/.

I'll consider this for a later improvement.

Thanks,
James

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://alioth-lists.debian.net/pipermail/pkg-php-pear/attachments/20200823/4f99271e/attachment.sig>