[pkg-php-pear] RFS: php-gettext-languages + php-oscarotero-gettext

[David Prévot]

Le 23/08/2020 à 14:39, James Valleroy a écrit :
> On 8/23/20 11:10 AM, David Prévot wrote:

php-gettext-languages
=====================

>> - bin/export-plural-rules should be patched to find the autoloader.php where it is installed, and could probably be installed in usr/bin (or the php-cli dependency should probably be dropped);
> 
> I removed the php-cli dependency.

0002-composer.json-Remove-bin-reference.patch incorrectly claims to be 
forwarded, and adds a newline at end of file (not really damaging for a 
Json file I guess, but you may really want to avoid that with PHP files, 
and so generally avoid it to stay on the safe side).

> The script is only installed as an example for now.

Yet, making it usable by pointing the correct autoloader.php would be an 
improvement.

- require_once dirname(__DIR__) . '/src/autoloader.php';
+ require_once 'Gettext/Languages/autoloader.php';

BTW, providing a static autoload.php (and use it rather than the dynamic 
autoloader.php one, while still providing it for compatibility reasons) 
would probably be an improvement.

php-oscarotero-gettext
======================

Same remark (providing a static autoload.php) for 
php-oscarotero-gettext, that would be especially useful to load the 
suggested packages.

CI is broken: it calls php instead of phpab. It also seems to be missing 
some dependencies (php-illuminate-database, php-symfony-yaml, php-twig, 
php-twig-extensions).


None of these remarks seem to be a blocker for NEW processing any, so 
both packages uploaded, thanks.

Regards

David
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_0xB82A217AFDFE09F2.asc
Type: application/pgp-keys
Size: 387118 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-php-pear/attachments/20200824/b5ebfebd/attachment-0001.key>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 840 bytes
Desc: OpenPGP digital signature
URL: <http://alioth-lists.debian.net/pipermail/pkg-php-pear/attachments/20200824/b5ebfebd/attachment-0001.sig>