[pkg-php-pear] RFS php-easyrdf 1.0.0-1

[David Prévot]

Hi Marco, Robin,

Le 02/12/2020 à 14:41, Robin Gustafsson a écrit :

> I cannot upload packages, but I had a look at the package anyway.

Thanks!

> General
> - You may want to sign your git tags
> - You may want to include and use upstream's test suite.

Agreed. Upstream has a “test-php8-compatibility” branch on top of its 
latest release that has compat with recent PHPUnit, so there should be 
little to fix in order to make it work during build and CI (skipping 
test related to ml/json-ld not yet in Debian for example).

> debian/tests/control
> - The .sh files should be set to executable and "Test-command: sh
> path/to/file.sh" should be just "Tests: file.sh"

I believe those tests are trivial, and thus must be marked as 
superficial as recently pointed by the release team. As is, the package 
is RC-buggy, so needs to be fixed.

https://release.debian.org/bullseye/freeze_policy.html

> debian/autoload.php.tpl
> - Looks like one of phpab's default templates. If so, it can be
> removed in favor of just letting phpab handle it.
> debian/control
> - php-mbstring isn't necessary in Depends as it's picked up
> automatically from composer.json.
> debian/docs
> - CHANGELOG.md should probably be installed by dh_installchangelogs in
> override_dh_installchangelogs instead.

No override even needed: the upstream changelog gets picked up 
automatically by dh_installchangelogs (as 
/u/s/d/php-easyrdf/changelog.gz), but anyway, agreed on all your other 
remarks.

I did not upload the package (because of the superficial tests not 
marked as such), nor did I review the upstream changes (will do once the 
package is fixed, eventually updated to a newer upstream version).

Regards

David