[pkg-php-pear] RFS php-easyrdf 1.0.0-1

Robin Gustafsson robin at rgson.se
Wed Dec 2 18:41:17 GMT 2020


Hi Marco,

> I would like to request an sponsor to upload the new packaged version of
> php-easyrdf[1].

I cannot upload packages, but I had a look at the package anyway.
Below is some feedback. None of this is critical, so deal with it as
you see fit.

General
- You may want to sign your git tags
- You may want to include and use upstream's test suite.
debian/tests/control
- The .sh files should be set to executable and "Test-command: sh
path/to/file.sh" should be just "Tests: file.sh"
debian/autoload.php.tpl
- Looks like one of phpab's default templates. If so, it can be
removed in favor of just letting phpab handle it.
debian/control
- php-mbstring isn't necessary in Depends as it's picked up
automatically from composer.json.
debian/docs
- CHANGELOG.md should probably be installed by dh_installchangelogs in
override_dh_installchangelogs instead.

Regards,
Robin



More information about the pkg-php-pear mailing list