[pkg-php-pear] Fwd: The phpMyAdmin package needs a review on a merge request

[William Desportes]

Hi David,



Thank you for having a look !



> (it sounds like you have everything 

under control)



This is true, everything builds and works fine ^^

Uploading to experimental is a very good idea, if anyone has my message in time I would need someone to enable me ACLs to the packages I maintain in order to be able to upload.

I have no idea why since I am a DM uploading does not work and gets rejected each time saying I do not have access.



Yes, the tests run fine and GitLab CI is running autopkgtests so I am sure everything works.

I pushed fixes for phpunit 9 on the google-recaptcha package and again the GitLab CI validated your fix for d/latest and b-backports.



> am not used to deal with Salsa webui (but I guess I can learn)



Well, it is quite cool. It feels like a GitHub and using issues and MR(PR) and the CI makes the packaging experience just perfect.



Also, I pushed a fix to make "php-twig (<< 4~~)," just to be sure next major will not be used by mistake. And dropped the useless restriction diff on our internal package.


Thanks for the feedback on the metro theme, removing it or fix lintian-overrides is the question now.

The file debian/phpmyadmin.lintian-overrides has some overrides and https://nm.debian.org/person/yadd/ pointed our that I should fix them.

But I have no idea how It should be done.

Overrides: font-in-non-font-package, font-outside-font-dir, truetype-font-prohibits-installable-embedding



So basically If I would make a checklist it would be:

- [ ] Have a DD let me know the package is Debian correct

- [ ] Find out how to fix the font-* overrides

- [ ] Be able to upload or have an uploader

- [ ] Link some more JS packages


Thank you for your help



William
---- Le mer., 30 déc. 2020 20:03:45 +0100 David Prévot <taffit at debian.org> écrit ----



Hi William, 
 
Le 30/12/2020 à 06:33, William Desportes a écrit : 
 
> I lack reviews and would need some expert eyeballs to have a look to 
> https://salsa.debian.org/phpmyadmin-team/phpmyadmin/-/merge_requests/30 
> I hope you can help me :) 
 
I just skimmed at the MR and the content of d/patches and am not sure 
what you are actually expecting (it sounds like you have everything 
under control). I’ve not tested the resulting package either but if you 
did, what is preventing you from an upload, at least to experimental in 
order to gather more feedback? I’ve also checked that the build time 
tests look fine with PHPUnit 9, so that’s a relief ;). 
 
Just a remark: simplify-composer-or-versions.patch seems currently 
useless: only php-twig-i18n-extension version 3 seems currently 
available, and if both php-twig 2 (from testing/unstable) and 3 (from 
experimental are usable, no version should be needed. OK, in order to 
allow smooth upgrade easier backports, “>2.9” may be worth it (but 
preventing the use of php-twig 3 seems counter-productive unless you’re 
already aware of existing issues), making it “>2.9, <4” should translate 
properly the current “^2.9 || ^3” without losing information when 
handled by dh_phpcomposer (as long as #765899 is not fixed). 
 
> Known issues: 
> - Metro theme has some fonts that I found out after another dev told me 
> Apache2 was not GPL2 compatible as beeing Apache2 files (extreme 
> possible solution: drop the theme on Debian): 
> https://github.com/phpmyadmin/phpmyadmin/pull/16547 
 
I’m not sure the issue is actually relevant: both licenses are DFSG 
compliant, and you’re not building a binary file with content from both 
license (the usual headache with incompatible licenses). As long as 
you’re providing content via separate files with a properly documented 
d/copyright, you’re as free to do it in the phpmyadmin package as the 
debian-cd team is free to provide packages from both licenses in the 
same ISO file. 
 
> Please let me know what you think about that 
 
I’ve just subscribed to the [team] list, am not used to deal with Salsa 
webui (but I guess I can learn), but please point mo to the relevant 
discussion media you’re using if I can help. 
 
team: https://tracker.debian.org/teams/phpmyadmin-team/ 
 
Regards 
 
David
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://alioth-lists.debian.net/pipermail/pkg-php-pear/attachments/20201230/1ac84f5b/attachment.html>