[pkg-php-pear] RFS: php-nikic-fast-route

[David Prévot]

Hi James,

Le 20/01/2020 à 04:21, James Valleroy a écrit :

> Please review and sponsor php-nikic-fast-route v1.3.0-1.

- Please provide d/gbp.conf (same reason as php-pubsubhubbub-publisher).

- Since you provide a static autoload.php, you need to make it load the
functions.php file documented in composer.json (not in the
vendor/autoload.php only built and used for tests).

https://salsa.debian.org/php-team/pear/php-nikic-fast-route/blob/debian/master/composer.json#L16

See e.g. php-guzzlehttp-promises:

https://salsa.debian.org/php-team/pear/php-guzzlehttp-promises/blob/master/composer.json#L23
https://salsa.debian.org/php-team/pear/php-guzzlehttp-promises/blob/master/debian/autoload.php.tpl#L3
https://salsa.debian.org/php-team/pear/php-guzzlehttp-promises/blob/master/debian/rules#L8

- Why install in /usr/share/php/Nikic/FastRoute instead of
/usr/share/php/FastRoute (that would be the expected path according to
the namespace)?

- I prefer having debian packaging built on top of the upstream
repository (using e.g., gbp import-orig --uscan --upstream-vcs-tag=), it
makes it easier to cherry-pick upstream commits among other things, but
you’re free to prefer otherwise (too late to change for this version,
but you can do that later if you change your mind ;).

Regards

David

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://alioth-lists.debian.net/pipermail/pkg-php-pear/attachments/20200202/a88f8935/attachment.sig>