[pkg-php-pear] RFS: php-nikic-fast-route

[James Valleroy]

Hi David,

On 2/2/20 5:08 AM, David Prévot wrote:
> Hi James,
> 
> - Please provide d/gbp.conf (same reason as php-pubsubhubbub-publisher).

Added.

> - Since you provide a static autoload.php, you need to make it load the
> functions.php file documented in composer.json (not in the
> vendor/autoload.php only built and used for tests).

Ok, I added autoload.php.tpl to load this file.

> - Why install in /usr/share/php/Nikic/FastRoute instead of
> /usr/share/php/FastRoute (that would be the expected path according to
> the namespace)?

That was a mistake, and would have caused problems later on. I've changed it to install in /usr/share/php/FastRoute. Thanks for catching this.

> - I prefer having debian packaging built on top of the upstream
> repository (using e.g., gbp import-orig --uscan --upstream-vcs-tag=), it
> makes it easier to cherry-pick upstream commits among other things, but
> you’re free to prefer otherwise (too late to change for this version,
> but you can do that later if you change your mind ;).

I'll keep this in mind for the next update.

Regards,
James

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://alioth-lists.debian.net/pipermail/pkg-php-pear/attachments/20200202/499a9827/attachment-0001.sig>