[pkg-php-pear] RFS: php-pubsubhubbub-publisher

[David Prévot]

Hi James and all,

Le 15/01/2020 à 02:48, James Valleroy a écrit :

> Please review and sponsor php-pubsubhubbub-publisher:

Thank you for your work. I’m OK to upload it as-is, but I wonder if
you’d like to use a lower version string before doing so (since that’s
the one thing one can’t decrease once the package is in).

A few details:

Did you forget to push your upstream/ (signed) tag?

A d/gbp.conf file would be useful since you use a non-default gbp scheme
(debian stuff in a d/master branch instead of master).

Don’t you need php-cli rather than php for CI?

The upstream version you chose (0.0~git20181009.047b0fa) ranks higher
than 0 or 0., why not simply use 0~something (or even 0~~something if
you want to be extra careful)?
Also, it looks like a long string: I don’t believe providing a short git
hash in the version string is useful (why not simply provide it inside
d/changelog?). Instead, it increases the data lentgh in every Debian box
(via its Package file) for a use case I doubt actually exists (and yes,
it’s your choice in the end ;). OK, it’s not as crazy as what some
people do in the nodejs world (e.g.,
6.2.1+ds+~0.4.0+~4.0.0+really4.0.0+~1.0.0+~5.0.1+ds+~1.7.0+ds+~0.1.1+~0.3.1+~0.2.0+~0.1.0+~0.3.0+~0.3.0-5
for acorn ;), I think they even managed to break the upload queue not so
long ago.

The upstream README.md could be shipped (I don’t mind either way).

> - Salsa CI is passing.

Nice, I really need to look into that.

Also, I’m interested in your d/watch, looks less ugly than my usual gbp
import-ref trick (I should also look closer into that, especially if it
allows one to drop a arbitrary file like .gitignore on update).

Regards

David

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://alioth-lists.debian.net/pipermail/pkg-php-pear/attachments/20200123/525d760d/attachment.sig>