[pkg-php-pear] RFS: php-pubsubhubbub-publisher

[David Prévot]

Hi James,

Le 23/01/2020 à 15:49, James Valleroy a écrit :
> On 1/23/20 7:49 AM, David Prévot wrote:
>> Le 15/01/2020 à 02:48, James Valleroy a écrit :
>>
>>> Please review and sponsor php-pubsubhubbub-publisher:

>> Did you forget to push your upstream/ (signed) tag?
> 
> I don't have an upstream/ tag yet, because I didn't run gbp import-ref (debian/master was directly branched from upstream).

I thought it would confuse gbp and/or pristine-tar but I was wrong (they
both work as far as I can tell).

>> The upstream version you chose (0.0~git20181009.047b0fa) ranks higher
>> than 0 or 0., why not simply use 0~something (or even 0~~something if
>> you want to be extra careful)?

> Yes, I can change this. I didn't find any guidelines for picking a version number, so I tried to match uscan's mode=git default.

The only guideline I’m aware of is in the New Maintainers' Guide:
https://www.debian.org/doc/manuals/maint-guide/first.en.html#namever

> Do you think I should keep the commit date in the version, like 0~~20181009? I can have uscan match this format with the "pretty" option.

I believe it’s the best option, yes.

Regards

David

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://alioth-lists.debian.net/pipermail/pkg-php-pear/attachments/20200124/c5e3db21/attachment.sig>