[pkg-php-pear] RFS: php-slim
jvalleroy at mailbox.org
Fri Mar 27 21:07:30 GMT 2020
On 3/26/20 4:03 PM, David Prévot wrote:
> Hi James,
> Le 23/03/2020 à 12:47, James Valleroy a écrit :
>> I have prepared php-slim 3.12.3-1 for initial upload to unstable.
> I realize you install the package in /usr/share/php/Slim/Slim but
> believe it should be installed in /usr/share/php/Slim instead (no need
> for double Slim, it uses the Slim namespace).
> Beside that, I noticed other details in my first pass (debian/ only),
> that wouldn’t have stopped me from uploading the package if it wasn’t
> for the previous remark.
> - https://www.slimframework.com/ should be used as Homepage
> (thanks to lintian-brush for the hint).
> - Standards-Version: 4.4.1 should be checked for 4.5.0.
> - “ln -s . Slim/Slim” is useless (and not cleaned up).
> - .phpunit.result.cache is missing.
> - You may wish to stick to version 3 if that’s what you’re targeting
> (I assume for the reverse-dependencies).
Thanks for the review. I have pushed fixes for each of these.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 833 bytes
Desc: OpenPGP digital signature
More information about the pkg-php-pear