[pkg-php-pear] deb packages looking for sponsorship
fabstz-it at yahoo.fr
Sat Jun 4 19:58:12 BST 2022
Dear James & David,
Sorry for the late reply James, I actually didn't receive your email (this
seems common for me with this list). David told me recently you replied.
I'm replying to both your e-mails below.
Le mardi 29 mars 2022 16:07:33 CEST, James Valleroy a écrit :
> On 3/20/22 06:48, Fab Stz wrote:
> > I uploaded these PHP packages to mentors.debian.net in the last weeks.
> > Would someone sponsor them?
> > - https://mentors.debian.net/package/php-codeigniter-framework/
> > - https://mentors.debian.net/package/php-league-csv/
> > - https://mentors.debian.net/package/php-kissifrot-php-ixr/
> > - https://mentors.debian.net/package/php-giggsey-locale/
> > - https://mentors.debian.net/package/php-giggsey-libphonenumber/
> > - https://mentors.debian.net/package/php-datto-json-rpc/
> > - https://mentors.debian.net/package/php-datto-json-rpc-http/
> > They are all also on https://salsa.debian.org/php-team/pear
> Are these libraries required for some end-user application(s) that you
> intend to package? I saw one that mentioned Kalkun, any others?
Yes, they are needed for Kalkun.
> - If the package is not yet in Debian, then IMO don't need to show
> multiple versions in the changelog. For example,
> php-codeigniter-framework can just have 3.1.13-1 as the "Initial
> release", and no other changes need to be listed.
Ok, as suggested by David, I started applying the changes for one package:
php-league-csv. I will update the other ones after this one is ok.
> - If there are no patches, then you can just remove the debian/patches/
> folder completely.
> - I noticed there is no pristine-tar branch, is it not used? It seems
> most packages in the team are using pristine-tar.
Should be fine now. I didn't follow what is now documented in the Wiki.
> - If there are tests from upstream, please run them during the package
> - Also please include debian/tests/ autopkgtests if possible. Even a
> trivial test is ok (if marked as Superficial).
Should be fine now thanks to the wiki.
> I will try to look in more detail later, and give a more thorough review.
Le vendredi 3 juin 2022, 12:48:42 CEST David Prévot a écrit :
This wiki mentions:
* `The package should also install upstream files in /usr/bin/php/
→ Did you actually mean /usr/share/php/<Vendor_name>/<Project_name> ?
→ does that package exist? is it necessary? It seems to work fine without it.
* could we move the "test" part of `dh` to `override_dh_auto_test`? This is
`mkdir --parents vendor <Vendor_name>` creates some interference when building
the package because the dirs are not in orig tarball.
* Since the packages used for the tests are already in d/control
What about using `@builddeps@` in the Depends field of d/tests/control ?
> > https://salsa.debian.org/php-team/pear/php-codeigniter-framework
> I had a quick look at the last one (it’s a bit unusual). Can you please
> point to a simple package in the list once you’ve applied the advice
> provided by James and the guideline?
Indeed, php-codeigniter-framework doesn't work the same way because it is a
framework and not a library. It has to be used in a specific way.
All other packages are simple and small except "php-giggsey-libphonenumber"
which is a little bit larger, but still similar. But if I remember well, each
debian packaging has to be a little bit different because sources differ
Let's start with php-league-csv. It should be ready for a new review now:
More information about the pkg-php-pear