[pkg-php-pear] Wiki feedback [Was: deb packages looking for sponsorship]

[David Prévot]

Hi,

Le 05/06/2022 à 13:30, Fab Stz a écrit :
> Le dimanche 5 juin 2022, 13:15:26 CEST David Prévot a écrit :
> 
>>> * dh-sequence-phpcomposer
[…]
>>              dh-sequence-addon implies a --with addon. This avoids
>>              the need for an explicit --with in debian/rules that
>>              only duplicates what is already declared via the build
>>              dependencies in debian/control.  The relation can (since
>>              12.5)
[…]
> What is the right/modern way that I should use then?
> - d/rules with `dh --with addon`
> - or d/control with `dh-sequence-addon` ?

The last one.

>>> * could we move the "test" part of `dh` to `override_dh_auto_test`? This
>>> is
>   because
>>> `mkdir --parents vendor <Vendor_name>` creates some interference when
>>> building
>   the package because the dirs are not in orig tarball.
[…]
> IIRC when cleaning and unpacking is done during dpkg-buildpackage it says that
> the directories created by `mkdir --parents vendor <Vendor_name>` in
> override_dh_auto_build are not in the orig tar, so dpkg-buildpackage failed.

I never notice such problem. That rather seems like a bug in our 
tooling. Can you please point to some reference, or report it if you’re 
able to reproduce it (I can’t).

> I changed the wiki and moved this part into this target:
> execute_before_dh_auto_test:
> I also move the first part to execute_before_dh_auto_build instead of
> override_dh_auto_build
> 
> Hopefully this is correct.

See above (i.e., not sure).

>>> * Since the packages used for the tests are already in d/control
>>> What about using `@builddeps@` in the Depends field of d/tests/control ?
>>
>> Checking that the package dependencies are correct is also part of the
>> autopkgtest features.
>>
>>       […]
>>       please use this sparingly, as this can easily lead to missing binary
>>       package dependencies being overlooked if they get pulled in via
>>       build dependencies.
[…]
> I'm not sure to understand the warning. The package in itself doesn't need the
> dependencies used in the tests (that I put in d/control's build-deps so that
> test target works), so I can use @builddeps@ in d/tests/control without
> problem right?

No. “Depends:” in d/t/control should only contain the additional 
dependencies needed to run the tests. It helps noticing, e.g., a missing 
package dependency (“Depends” in d/control) during the tests. 
@builddeps@ is like a WMD that helps when the tests needs so many 
packages that it’s a PITA to synchronize everything. Few packages, if 
any, on top of the usual three (phpab, phpunit, pkg-php-tools) does not 
qualify as a good use of this WMD.

> (please leave my email in the recipients when doing a reply to all since some
> messages seems to not arrive on the mail I used to subscribe to the list)

Done, but please, do not CC me, as per our lists CoC.

	https://www.debian.org/MailingLists/#codeofconduct

Regards

David
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 495 bytes
Desc: OpenPGP digital signature
URL: <http://alioth-lists.debian.net/pipermail/pkg-php-pear/attachments/20220606/49797e47/attachment.sig>