[pkg-php-pear] Wiki feedback [Was: deb packages looking for sponsorship]

[Fab Stz]

Hi David,

Le dimanche 5 juin 2022, 13:15:26 CEST David Prévot a écrit :

> > * dh-sequence-phpcomposer
> > → does that package exist? is it necessary? It seems to work fine without
> > it.
> 
> It’s provided by pkg-php-tools, so you don’t need to B-D on 
> pkg-php-tools nor use “--with phpcomposer” with dh, see dh(1):
> 
>             dh-sequence-addon implies a --with addon. This avoids
>             the need for an explicit --with in debian/rules that
>             only duplicates what is already declared via the build
>             dependencies in debian/control.  The relation can (since
>             12.5) be made optional via e.g.  build-profiles.  This
>             enables you to easily disable an addon that is only
>             useful with certain profiles (e.g. to facilitate
>             bootstrapping).

What is the right/modern way that I should use then?
- d/rules with `dh --with addon`
- or d/control with `dh-sequence-addon` ?

> > * could we move the "test" part of `dh` to `override_dh_auto_test`? This
> > is
 because
> > `mkdir --parents vendor <Vendor_name>` creates some interference when
> > building
 the package because the dirs are not in orig tarball.
> 
> 
> I don’t understand, what interference are you talking about? I *think* 
> that this kind of things (building autoload.php for tests and other 
> workaround to not use composer) are more dh_auto_build materials than 
> dh_auto_test ones. Does someone have any good arguments about that, or 
> any strong feelings?

IIRC when cleaning and unpacking is done during dpkg-buildpackage it says that 
the directories created by `mkdir --parents vendor <Vendor_name>` in 
override_dh_auto_build are not in the orig tar, so dpkg-buildpackage failed.

I changed the wiki and moved this part into this target:  
execute_before_dh_auto_test:
I also move the first part to execute_before_dh_auto_build instead of 
override_dh_auto_build

Hopefully this is correct.

> > * Since the packages used for the tests are already in d/control
> > What about using `@builddeps@` in the Depends field of d/tests/control ?
> 
> Checking that the package dependencies are correct is also part of the 
> autopkgtest features.
> 
>      […]
>      please use this sparingly, as this can easily lead to missing binary
>      package dependencies being overlooked if they get pulled in via
>      build dependencies.
> 
> https://salsa.debian.org/ci-team/autopkgtest/raw/master/doc/README.package-t
> ests.rst

I'm not sure to understand the warning. The package in itself doesn't need the 
dependencies used in the tests (that I put in d/control's build-deps so that 
test target works), so I can use @builddeps@ in d/tests/control without 
problem right?

(please leave my email in the recipients when doing a reply to all since some 
messages seems to not arrive on the mail I used to subscribe to the list)

Rgds
Fab