[pkg-php-pear] deb packages looking for sponsorship

[David Prévot]

Hi,

Le 04/06/2022 à 20:58, Fab Stz a écrit :

> Let's start with php-league-csv. It should be ready for a new review now:
> * https://salsa.debian.org/php-team/pear/php-league-csv

I notice you committed the templates from phpabtpl(1), do you intend to 
push those packages in areas where pkg-php-tools is not yet in 1.41?

You should not install the testsuite (src/*Test.php files).

d/control

You don’t need pkg-php-tools in Build-Depends (dh-sequence-phpcomposer 
is provided by pkg-php-tools since 1.40 IIRC).
php-xdebug seems also useless.

d/copyright

This MIT license is called Expat in Debian.
You don’t need the four first lines (license name and copyright) 
especially since you claim copyright on debian/ with the same license.
Source field shouldn’t contain less than and greater than characters.
Copyright years do not match what is documented upstream in the package.

Running lintian-brush(1) will create debian/upstream/metadata for you.

d/tests/control

The purpose of autopkgtest is to test the *installed* package, so you 
must not make a League directory and League/Csv symlink: it will force 
to use the source (that’s only useful at build time since the package is 
not yet built).
php-xdebug is not needed either AFAICT.
The testsuite requires Internet, so needs-internet should be added to 
Restrictions.

Furthermore, buildd do not have Internet access during the build, so the 
testsuite must be amended (e.g., filtering away the test or data set 
requiring Internet) to run there (at build time, via dh_auto_test):

There was 1 error:

1) League\Csv\AbstractCsvTest::testGetPathname with data set "external 
uri" ('https://raw.githubusercontent...oo.csv', 
'https://raw.githubusercontent...oo.csv')
League\Csv\UnavailableStream: 
`https://raw.githubusercontent.com/thephpleague/csv/8.2.3/test/data/foo.csv`: 
failed to open stream: No such file or directory.

/build/php-league-csv-9.8.0/src/UnavailableStream.php:25
/build/php-league-csv-9.8.0/src/Stream.php:128
/build/php-league-csv-9.8.0/src/AbstractCsv.php:117
/build/php-league-csv-9.8.0/src/Reader.php:50
/build/php-league-csv-9.8.0/src/AbstractCsvTest.php:497

I guess php-curl will become useless at build time.

Regards

David

P.-S.: I usually run wrap-and-sort(1) to get an unified output, what 
tool (or options) do you use (it doesn’t seem to sort the same way)?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 495 bytes
Desc: OpenPGP digital signature
URL: <http://alioth-lists.debian.net/pipermail/pkg-php-pear/attachments/20220611/bd7305d3/attachment.sig>