[pkg-php-pear] Getting pkg-php-tools 1.45 into unstable

[Robin Gustafsson]

Hi Athos,

On 6/1/24 14:54, Athos Ribeiro wrote:
> On Sun, May 26, 2024 at 12:51:50AM +0200, Robin Gustafsson wrote:
>> Hi team,
> 
> Ho Robin,
> 
>> I'd like to get pkg-php-tools 1.45 into unstable. Are we ready for that?
>>
>> Version 1.45 contains the fix for phpabtpl to force system dependency 
>> loading [1]. It'd let us use phpabtpl again. However, it breaks some 
>> build tests: those where phpabtpl is used to make a test-specific 
>> autoloader that loads the package's own autoloader from the build 
>> directory by relying on PHP's include path.
> 
> Thanks!

The thanks go to David for that one. :-)

>> pkg-php-tools 1.45 has been in experimental since 2024-03-03. Only two 
>> blockers are shown in the experimental pseudo-excuses [2]. More 
>> packages will FTBFS in unstable though; the pseudo-excuses page shows 
>> only autopkgtest failures.
>>
>> Do we have tools to find the FTBFS cases before we upload to unstable?
> 
> I like to use a script from the Ruby team called mass-rebuild combined
> with collab-qa-tools, a set of scripts Lucas Nussbaum uses when doing
> archive rebuilds (you can learn more about it in this Antonio Terceiro
> post here
> https://terceiro.xyz/2021/10/12/triaging-debian-build-failure-logs-with-collab-qa-tools/).
> 
> The last run I performed was for phpunit 11. You can see the results
> here http://people.ubuntu.com/~athos-ribeiro/rebuilds/phpunit11/.
> 
> Then, with collab-qa-tools, I reported the following bug list:
> https://udd.debian.org/cgi-bin/bts-usertags.cgi?user=pkg-php-pear%40lists.alioth.debian.org&tag=phpunit11

Interesting! Thanks for the extra material and examples.

>> I've proposed fixes for both broken packages on Salsa [3][4]. My fix 
>> uses phpabtpl's `--require-file` option to explicitly load the local 
>> autoload.php files.
>>
>> Does anyone see a problem with this approach?
>>
>>
>> If there are no objections or other suggestions, I'll proceed to merge 
>> my patches for these two packages and upload pkg-php-tools 1.45 to 
>> unstable. (After some delay, if nobody beats me to it.)
> 
> No objections here. Still, I could perform a mass-rebuild on reverse
> build dependencies and report bugs if I find any as we did for phpunit
> (just let me know if this would help).

I think that'd be great. Then we can better grasp the extent of the 
breakage and hopefully fix some packages beforehand.

Keep in mind that pkg-php-tools also "Provides: dh-sequence-phpcomposer, 
dh-sequence-phppear", in case the tools don't find that automatically.

>> [1] 
>> https://salsa.debian.org/php-team/pear/pkg-php-tools/-/commit/589bf21dec363c3b4ccc434d1d7750e6abb6c54b
>> [2] 
>> https://qa.debian.org/excuses.php?experimental=1&package=pkg-php-tools
>> [3] 
>> https://salsa.debian.org/php-team/pear/php-giggsey-locale/-/merge_requests/1
>> [4] 
>> https://salsa.debian.org/php-team/pear/php-giggsey-libphonenumber/-/merge_requests/1
> 

-- 
Regards,
Robin

GPG: B26C 2ED3 7324 6221 9C3D 1DFE 293A 3C91 D188 369C
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature.asc
Type: application/pgp-signature
Size: 840 bytes
Desc: OpenPGP digital signature
URL: <http://alioth-lists.debian.net/pipermail/pkg-php-pear/attachments/20240603/e46b2e21/attachment-0001.sig>