Bug#666283: proftpd-mod-msg: FTBFS: mod_msg.c:314:5: error: format not a string literal and no format arguments [-Werror=format-security]

[Lucas Nussbaum]

Source: proftpd-mod-msg
Version: 0.4.1-1
Severity: serious
Tags: wheezy sid
User: debian-qa at lists.debian.org
Usertags: qa-ftbfs-20120330 qa-ftbfs qa-ftbfs-buildarch
Justification: FTBFS on amd64

Hi,

During a rebuild of all packages in sid, your package failed to build on
amd64.

This rebuild was done by building only architecture:any binary packages
(binary-arch target of debian/rules), and using a newer dpkg that uses the
build-arch target if available.
Also, only the Build-Depends were installed, not the Build-Depends-Indep.

Relevant part:
> make[1]: Entering directory `/«PKGBUILDDIR»'
> DESTDIR=/«PKGBUILDDIR»/debian/proftpd-mod-msg prxs -c mod_msg.c
> libtool --mode=compile gcc  -DLINUX -g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat -Wformat-security -Werror=format-security -Wall -DPR_SHARED_MODULE -I. -I/usr/include/proftpd -c mod_msg.c
> libtool: compile:  gcc -DLINUX -g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat -Wformat-security -Werror=format-security -Wall -DPR_SHARED_MODULE -I. -I/usr/include/proftpd -c mod_msg.c  -fPIC -DPIC -o .libs/mod_msg.o
> mod_msg.c: In function 'msg_post_any':
> mod_msg.c:314:5: error: format not a string literal and no format arguments [-Werror=format-security]
> mod_msg.c: In function 'msg_post_err_any':
> mod_msg.c:346:5: error: format not a string literal and no format arguments [-Werror=format-security]
> mod_msg.c: In function 'msg_handle_msg':
> mod_msg.c:713:11: warning: format '%u' expects argument of type 'unsigned int', but argument 4 has type 'char *' [-Wformat]
> mod_msg.c:713:11: warning: format '%s' expects argument of type 'char *', but argument 5 has type 'pid_t' [-Wformat]
> mod_msg.c:713:11: warning: too many arguments for format [-Wformat-extra-args]
> cc1: some warnings being treated as errors
> prxs: error executing command (1)
> make[1]: *** [override_dh_auto_build] Error 1

The full build log is available from:
   http://people.debian.org/~lucas/logs/2012/03/30/proftpd-mod-msg_0.4.1-1_unstable.log

A list of current common problems and possible solutions is available at 
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

About the archive rebuild: The rebuild was done on about 50 AMD64 nodes
of the Grid'5000 platform, using a clean chroot.  Internet was not
accessible from the build systems.