Bug#836759: proftpd-dfsg: please drop the build dependency on hardening-wrapper

[Mattia Rizzolo]

On Thu, Oct 06, 2016 at 06:55:22PM +0200, Hilmar Preuße wrote:
> On 01.10.2016 19:01, Mattia Rizzolo wrote:
> > Can you also upload it?
> I'm not a DD (yet), I can't do upload.
> 
> I know we have DD's on that list: could anybody finalize the changelog
> in git and then upload the current git state?

I can sponsor the upload if you want, but before I'd like to see more
changes done, meaning:
1) both Vcs-Git and Vcs-Browser canonicalized to (it works for both)
        https://anonscm.debian.org/git/pkg-proftpd/proftpd-dfsg.git
2) build done by dh_auto_build, instead of manual `make all`
3) configure done by dh_auto_configure
4) compat level bumped to at least 9, so that buildflags from
   dpkg-buidflags are exported by dh_* tools (read debhelper(7))
5) config.{sub,guess} updated by dh_update_autotools_config (just call
   it instead of that `test -r / mv / cp` + cleanup; the cleanup is done
   by dh_clean)
6) run dh_autoreconf
7) there are so many trailing whitespaces in that d/rules...
8) install done with dh_auto_install.  That nostrip facility is not
   needed, the strip is done by dh_strip anyway, also stripping the
   binaries at install time like that makes the -dbgsym binaries
   produced by dh_strip useless
9) now that you're like this you can reinstate hardening, that you
   removed but not replaced, so just put
       export DEB_BUILD_MAINT_OPTIONS = hardening=+all
   on top, it should just work after the changs above
10) moving to dh_* tools makes you posible to drop:
  + thing for supporting cross build (the
     `ifeq ($(DEB_BUILD_GNU_TYPE),$(DEB_HOST_GNU_TYPE))`
    )
  + that `CC := gcc`, that it's also breaking cross compiling, I think
    (haven't tried)
11) the rules' clean target doesn't call dh_auto_clean.  I think that
    with it you can save a lot of manual `rm -rf` and also revert
    adf6a7e88b051ed2fa7e7638d41d9105aa3c603c
12) I wouldn't mind seeing those `install ...` moved to the already
    existing d/*.install files
13) the -l option of dh_shlibdeps is really unneeded nowadays
14) you have a `CFLAGS := ..` on the top, but it's not exported, hence
    it's just about useless
15) after all of this you will see how most of d/rules turned into "just
    call calling dh_*", and eventually rewriting the whole thing to use
    the dh(1) sequencer with just a couple of overrides will be very
    easy....
16) given that you're preparing the upload, your name should be in the
    trailing of d/changelog, imho, then you're not in the Uploaders
    field, so you either should be there, or stick a "Team upload" in
    the beginning.

Then, that's assuming you're interested in having me as a sponsor, and
nobody else steps up :)
(also, I'm not in the team, so I can't push commit/tags)

-- 
regards,
                        Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540      .''`.
more about me:  https://mapreri.org                             : :'  :
Launchpad user: https://launchpad.net/~mapreri                  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-proftpd-maintainers/attachments/20161006/fe7514b9/attachment.sig>