[SCM] pulseaudio packaging branch, master, updated. debian/0.9.22-1-8-gb154901

crimsun-guest at users.alioth.debian.org crimsun-guest at users.alioth.debian.org
Sat Jun 11 22:30:58 UTC 2011


The branch, master has been updated
       via  b154901753b90a6f3e9c07dbf73c374d2e3a3b6c (commit)
      from  669299a7e4853d5563cc4e18d6bceb34efaa160f (commit)


- Shortlog ------------------------------------------------------------
b154901 Apply patch from Arnaud Fontaine <arnau at debian.org> and suggestion from Alessandro Ghedini <al3xbio at gmail.com> to fix FTBFS with xcb-util 0.3.8 (#624847). libxcb-util0-dev completely replaces libxcb-atom1-dev and already depends on libxcb1-dev.

Summary of changes:
 debian/changelog                                   |    7 +-
 debian/control                                     |    2 +-
 .../0004-Fix-FTBFS-with-xcb-util-0.3.8.patch       |  102 ++++++++++++++++++++
 debian/patches/series                              |    1 +
 4 files changed, 110 insertions(+), 2 deletions(-)
-----------------------------------------------------------------------
Details of changes:

commit b154901753b90a6f3e9c07dbf73c374d2e3a3b6c
Author: Daniel T Chen <crimsun at ubuntu.com>
Date:   Sat Jun 11 18:16:36 2011 -0400

    Apply patch from Arnaud Fontaine <arnau at debian.org> and suggestion from
    Alessandro Ghedini <al3xbio at gmail.com> to fix FTBFS with xcb-util 0.3.8
    (#624847). libxcb-util0-dev completely replaces libxcb-atom1-dev and
    already depends on libxcb1-dev.

diff --git a/debian/changelog b/debian/changelog
index f6a9f37..f1ef663 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -13,12 +13,17 @@ pulseaudio (0.9.22-2) UNRELEASED; urgency=low
     + Mention speex in the resampling section. Currently the Resampler
       section of "Programming with Speex (the libspeex API)" contains
       the relevant information (Closes: #541206)
+  * debian/patches/0004-Fix-FTBFS-with-xcb-util-0.3.8.patch:
+    + Apply patch from Arnaud Fontaine <arnau at debian.org> and the
+      suggestion from Alessandro Ghedini <al3xbio at gmail.com> to fix
+      FTBFS with xcb-util 0.3.8. Thanks, Arnaud and Alessandro!
+      (Closes: #624847)
   * debian/pulseaudio-utils.links: Also add pamon(1), parec(1), and
     parecord(1) (Closes: #599696)
   * debian/README.Debian: Clarify historical pulse-rt use and document
     current recommendation of RealtimeKit (Closes: #548363)
 
- -- Daniel T Chen <crimsun at ubuntu.com>  Sat, 18 Dec 2010 20:26:47 -0500
+ -- Daniel T Chen <crimsun at ubuntu.com>  Sat, 11 Jun 2011 18:26:18 -0400
 
 pulseaudio (0.9.22-1) experimental; urgency=low
 
diff --git a/debian/control b/debian/control
index dc793f9..1d7e8b6 100644
--- a/debian/control
+++ b/debian/control
@@ -16,7 +16,7 @@ Build-Depends: debhelper (>= 5), cdbs, quilt, m4, libltdl-dev (>= 2.2.6a-2),
     libbluetooth-dev (>= 4.40) [!kfreebsd-i386 !kfreebsd-amd64 !hurd-i386],
     libgdbm-dev, intltool, libgtk2.0-dev, libxtst-dev,
     libssl-dev,
-    libx11-xcb-dev, libice-dev, libxcb-atom1-dev
+    libx11-xcb-dev, libice-dev, libxcb-util0-dev
 Standards-Version: 3.8.1
 Vcs-Git: git://git.debian.org/git/pkg-pulseaudio/pulseaudio.git
 Vcs-Browser: http://git.debian.org/?p=pkg-pulseaudio/pulseaudio.git
diff --git a/debian/patches/0004-Fix-FTBFS-with-xcb-util-0.3.8.patch b/debian/patches/0004-Fix-FTBFS-with-xcb-util-0.3.8.patch
new file mode 100644
index 0000000..8ab3f86
--- /dev/null
+++ b/debian/patches/0004-Fix-FTBFS-with-xcb-util-0.3.8.patch
@@ -0,0 +1,102 @@
+diff --git a/configure.ac b/configure.ac
+index dea8bb9..d31f561 100644
+--- a/configure.ac
++++ b/configure.ac
+@@ -516,7 +516,7 @@ AC_ARG_ENABLE([x11],
+         [x11=auto])
+ 
+ if test "x${x11}" != xno ; then
+-    PKG_CHECK_MODULES(X11, [ x11-xcb ice sm xtst xcb-atom ],
++    PKG_CHECK_MODULES(X11, [ x11-xcb xcb >= 1.6 ice sm xtst ],
+         HAVE_X11=1,
+         [
+             HAVE_X11=0
+diff --git a/src/pulsecore/x11prop.c b/src/pulsecore/x11prop.c
+index 4cb21da..1c0d199 100644
+--- a/src/pulsecore/x11prop.c
++++ b/src/pulsecore/x11prop.c
+@@ -30,7 +30,6 @@
+ #include <pulsecore/macro.h>
+ 
+ #include <xcb/xproto.h>
+-#include <xcb/xcb_atom.h>
+ 
+ #define PA_XCB_FORMAT 8
+ 
+@@ -50,28 +49,43 @@ static xcb_screen_t *screen_of_display(xcb_connection_t *xcb, int screen)
+ 
+ void pa_x11_set_prop(xcb_connection_t *xcb, int screen, const char *name, const char *data) {
+     xcb_screen_t *xs;
+-    xcb_atom_t a;
++    xcb_intern_atom_reply_t *reply;
+ 
+     pa_assert(xcb);
+     pa_assert(name);
+     pa_assert(data);
+ 
+     if ((xs = screen_of_display(xcb, screen))) {
+-        a = xcb_atom_get(xcb, name);
+-        xcb_change_property(xcb, XCB_PROP_MODE_REPLACE, xs->root, a, STRING, PA_XCB_FORMAT, (int) strlen(data), (const void*) data);
++        reply = xcb_intern_atom_reply(xcb,
++                                      xcb_intern_atom(xcb, 0, strlen(name), name),
++                                      NULL);
++
++        if (reply) {
++            xcb_change_property(xcb, XCB_PROP_MODE_REPLACE, xs->root, reply->atom,
++                                XCB_ATOM_STRING, PA_XCB_FORMAT,
++                                (int) strlen(data), (const void*) data);
++
++            free(reply);
++        }
+     }
+ }
+ 
+ void pa_x11_del_prop(xcb_connection_t *xcb, int screen, const char *name) {
+     xcb_screen_t *xs;
+-    xcb_atom_t a;
++    xcb_intern_atom_reply_t *reply;
+ 
+     pa_assert(xcb);
+     pa_assert(name);
+ 
+     if ((xs = screen_of_display(xcb, screen))) {
+-        a = xcb_atom_get(xcb, name);
+-        xcb_delete_property(xcb, xs->root, a);
++        reply = xcb_intern_atom_reply(xcb,
++                                      xcb_intern_atom(xcb, 0, strlen(name), name),
++                                      NULL);
++
++        if (reply) {
++        xcb_delete_property(xcb, xs->root, reply->atom);
++            free(reply);
++        }
+     }
+ }
+ 
+@@ -81,7 +95,7 @@ char* pa_x11_get_prop(xcb_connection_t *xcb, int screen, const char *name, char
+     xcb_get_property_cookie_t req;
+     xcb_get_property_reply_t* prop = NULL;
+     xcb_screen_t *xs;
+-    xcb_atom_t a;
++    xcb_intern_atom_reply_t *reply;
+ 
+     pa_assert(xcb);
+     pa_assert(name);
+@@ -99,9 +113,15 @@ char* pa_x11_get_prop(xcb_connection_t *xcb, int screen, const char *name, char
+         xs = screen_of_display(xcb, 0);
+ 
+     if (xs) {
+-        a = xcb_atom_get(xcb, name);
++        reply = xcb_intern_atom_reply(xcb,
++                                      xcb_intern_atom(xcb, 0, strlen(name), name),
++                                      NULL);
++
++        if (!reply)
++            goto finish;
+ 
+-        req = xcb_get_property(xcb, 0, xs->root, a, STRING, 0, (uint32_t)(l-1));
++        req = xcb_get_property(xcb, 0, xs->root, reply->atom, XCB_ATOM_STRING, 0, (uint32_t)(l-1));
++        free(reply);
+         prop = xcb_get_property_reply(xcb, req, NULL);
+ 
+         if (!prop)
diff --git a/debian/patches/series b/debian/patches/series
index 29ff672..592c893 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -1,3 +1,4 @@
 0001-Work-around-some-platforms-not-having-O_CLOEXEC.patch
 0002-In-KDE-only-start-pulseaudio-from-the-KDE-specific-d.patch
 0003-Mention-speex-and-libsamplerate-in-pulse-daemon.conf.patch
+0004-Fix-FTBFS-with-xcb-util-0.3.8.patch

-- 
pulseaudio packaging



More information about the pkg-pulseaudio-devel mailing list