Bug#900856: enlightenment: Sound fails to work after upgrade

[Felipe Sateler]

Hi Mike,

On Thu, Jun 28, 2018 at 6:15 PM Mike Brodbelt <mike at coruscant.org.uk> wrote:

> On 21/06/18 12:34, Felipe Sateler wrote:
>
> > Patches welcome. If you decide to implement this, make sure that the
> > code is only active with a running sysvinit (ie, don't affect chroots).
> > It is not trivial, which is why I didn't implement it myself. You
> > probably need to integrate ucf to handle all the corner cases.
>
> Patch attached.


Thanks. However, it has some flaws that need to be reworked for this to
work at all:

1. We can't rely on gcc being installed
2. It doesn't check /proc is actually mounted
3. dpkg status check is racy: sysvinit might be upgraded at the same time,
and thus not be "installed"
4. dpkg status check is for the wrong package: sysvinit no longer exists (I
think you want sysvinit-core).
5. The postinst should be the one for libpulse0, not pulseaudio

I would suggest poking around in /proc/1/ instead to check for sysvinit.


> I haven't gone through all the steps of integrating ucf
> - the disable autospawn file isn't currently marked in the package as a
> conffile, so this patch, while it works in my limited testing, could
> still be improved on there.
>

You missed the conffile mark because it is shipped in libpulse0 :)


>
> LMK what you think - if you're happy with this approach and will
> integrate it, I can work on ucf integration as well.
>

I don't have objections in principle, but I want a good and relatively
not-risky implementation first.

BTW, it might be easier to do the review/fixup dance in a merge request on
salsa: https://salsa.debian.org/pulseaudio-team/pulseaudio

-- 

Saludos,
Felipe Sateler
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://alioth-lists.debian.net/pipermail/pkg-pulseaudio-devel/attachments/20180628/09914755/attachment.html>