Bug#958286: pavucontrol: Missing escaping of & in device names

[Tollef Fog Heen]

]] Felipe Sateler 

> So, I could not reproduce the issue by setting bluez.alias either. 
> 
> Does the console error happen on applicatin startup? Or when switching to a given tab?

It shows up when the device connects, so either at startup or when I
turn on the headphones.

I think maybe the problem is related to the «Configuration» tab, since
the headset is listed there with just «Card Name» as the name.  It's
shown correctly on both the Playback and Output Devices tabs.

--- pavucontrol-4.0.orig/src/mainwindow.cc
+++ pavucontrol-4.0/src/mainwindow.cc
@@ -368,7 +368,7 @@ void MainWindow::updateCard(const pa_car
 
     description = pa_proplist_gets(info.proplist, PA_PROP_DEVICE_DESCRIPTION);
     w->name = description ? description : info.name;
-    w->nameLabel->set_markup(w->name.c_str());
+    w->nameLabel->set_text(w->name.c_str());
 
     icon = pa_proplist_gets(info.proplist, PA_PROP_DEVICE_ICON_NAME);
     set_icon_name_fallback(w->iconImage, icon ? icon : "audio-card", Gtk::ICON_SIZE_SMALL_TOOLBAR);

seems to fix it for me.  (You could also use g_markup_printf_escaped, I
guess).

-- 
Tollef Fog Heen
UNIX is user friendly, it's just picky about who its friends are