Bug#958286: pavucontrol: Missing escaping of & in device names

[Felipe Sateler]

On Sat, Apr 25, 2020 at 2:34 AM Tollef Fog Heen <tfheen at err.no> wrote:

> ]] Felipe Sateler
>
> > So, I could not reproduce the issue by setting bluez.alias either.
> >
> > Does the console error happen on applicatin startup? Or when switching
> to a given tab?
>
> It shows up when the device connects, so either at startup or when I
> turn on the headphones.
>
> I think maybe the problem is related to the «Configuration» tab, since
> the headset is listed there with just «Card Name» as the name.  It's
> shown correctly on both the Playback and Output Devices tabs.
>

Ah, so it is the "card" that is the problem, not the sink. That explains
why I couldn't reproduce.



>
> --- pavucontrol-4.0.orig/src/mainwindow.cc
> +++ pavucontrol-4.0/src/mainwindow.cc
> @@ -368,7 +368,7 @@ void MainWindow::updateCard(const pa_car
>
>      description = pa_proplist_gets(info.proplist,
> PA_PROP_DEVICE_DESCRIPTION);
>      w->name = description ? description : info.name;
> -    w->nameLabel->set_markup(w->name.c_str());
> +    w->nameLabel->set_text(w->name.c_str());
>
>      icon = pa_proplist_gets(info.proplist, PA_PROP_DEVICE_ICON_NAME);
>      set_icon_name_fallback(w->iconImage, icon ? icon : "audio-card",
> Gtk::ICON_SIZE_SMALL_TOOLBAR);
>
> seems to fix it for me.  (You could also use g_markup_printf_escaped, I
> guess).
>

I see now that this is already fixed in upstream git. I'll upload the fix
shortly.

-- 

Saludos,
Felipe Sateler
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://alioth-lists.debian.net/pipermail/pkg-pulseaudio-devel/attachments/20200425/ad9bba86/attachment.html>