[Pkg-puppet-devel] Commit practices, code review, etc

[Stig Sandbeck Mathisen]

Andrew Pollock <apollock at debian.org> writes:

> Coming from Google, I'm totally sold on principle of doing code
> reviews prior to submitting changes.
>
> I feel that at the moment, we're all just commiting changes to the Git
> repository on Alioth in a fairly uncoordinated manner. If we had a
> code review prior to a commit, this would at least give everyone
> advance warning of an impending commit.

I've no experience with code review tools, but having a way to review
commits before they enter the master branch on alioth would be an
improvement.

> The question is how to insert this into the workflow? I know of
> Gerrit, which seems pretty cool, because it's like the code review
> tool we use internally at Google. I don't know much about how it
> integrates with Git, or what it would take to spin up an instance of
> it (I think it's Java-based).

I have no preference.

> It seems like one for all of Alioth would be the way go.

I'm not sure what you mean here. :)

> Anyone got any thoughts on this?

If your experience says that it improves the quality of the teamwork, I
would like to try using it, and see if it helps with coordinating.

-- 
Stig Sandbeck Mathisen
                      ooo, shiny!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-puppet-devel/attachments/20100217/076e321e/attachment.pgp>