[Pkg-puppet-devel] Commit practices, code review, etc

[Andrew Pollock]

On Wed, Feb 17, 2010 at 11:20:56PM +0100, Stig Sandbeck Mathisen wrote:
> Andrew Pollock <apollock at debian.org> writes:
> 
> > Coming from Google, I'm totally sold on principle of doing code
> > reviews prior to submitting changes.
> >
> > I feel that at the moment, we're all just commiting changes to the Git
> > repository on Alioth in a fairly uncoordinated manner. If we had a
> > code review prior to a commit, this would at least give everyone
> > advance warning of an impending commit.
> 
> I've no experience with code review tools, but having a way to review
> commits before they enter the master branch on alioth would be an
> improvement.
> 
> > The question is how to insert this into the workflow? I know of
> > Gerrit, which seems pretty cool, because it's like the code review
> > tool we use internally at Google. I don't know much about how it
> > integrates with Git, or what it would take to spin up an instance of
> > it (I think it's Java-based).
> 
> I have no preference.
> 
> > It seems like one for all of Alioth would be the way go.
>
> I'm not sure what you mean here. :)
 
I mean rather than invent something for pkg-puppet on Alioth, if Alioth
provided this infrastructure for all Alioth-hosted projects, it'd be better
to do it that way.

> > Anyone got any thoughts on this?
> 
> If your experience says that it improves the quality of the teamwork, I
> would like to try using it, and see if it helps with coordinating.

I think it would definitely improve quality and communication, it just comes
down to how to do it.

A lightweight start would be to start emailing patches around instead of
committing them first, perhaps.

I need to look at Gerrit some more.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-puppet-devel/attachments/20100218/03b44f33/attachment-0001.pgp>