[Pkg-puppet-devel] [SCM] Puppet packaging for Debian branch, experimental, updated. debian/2.6.8-1-844-g7ec39d5

[Matt Robinson]

The following commit has been merged in the experimental branch:
commit 174e87a9b150a06a4ff9d696a6008fc08b05568b
Author: Matt Robinson <matt at puppetlabs.com>
Date:   Thu Apr 14 11:33:03 2011 -0700

    (#4258) Fix pkgutil spec test to have the correct provider
    
    The resource being used for testing didn't explicitly set the provider,
    so it ended up using whatever the default provider was on the system on
    which it was run.  This was problematic when running the specs on a Mac
    since the default provider is pkgdmg and that provider doesn't seem to
    be upgradeable.  So when you tried:
    
        @resource[:ensure] = :latest
    
    You got the error:
    
        1) Puppet::Type::Package::ProviderPkgutil when installing should use a command without versioned package
         Failure/Error: @resource[:ensure] = :latest
         Puppet::Error: Parameter ensure failed: Provider must have features 'upgradeable' to set 'ensure' to 'latest'
         # ./lib/puppet/parameter.rb:171:in `fail'     # ./lib/puppet/parameter.rb:257:in `validate'
         # ./lib/puppet/property.rb:300:in `should='     # ./lib/puppet/property.rb:300:in `each'
         # ./lib/puppet/property.rb:300:in `should='     # ./lib/puppet/property.rb:337:in `value='
         # ./lib/puppet/type.rb:416:in `[]='     # ./spec/unit/provider/package/pkgutil_spec.rb:35
    
    Reviewed-by: Daniel Pittman <daniel at puppetlabs.com>

diff --git a/spec/unit/provider/package/pkgutil_spec.rb b/spec/unit/provider/package/pkgutil_spec.rb
index f1d21f4..5549b3f 100755
--- a/spec/unit/provider/package/pkgutil_spec.rb
+++ b/spec/unit/provider/package/pkgutil_spec.rb
@@ -6,8 +6,11 @@ provider = Puppet::Type.type(:package).provider(:pkgutil)
 
 describe provider do
   before(:each) do
-    @resource = stub 'resource'
-    @resource = Puppet::Type.type(:package).new(:name => "TESTpkg", :ensure => :present)
+    @resource = Puppet::Type.type(:package).new(
+      :name     => "TESTpkg",
+      :ensure   => :present,
+      :provider => :pkgutil
+    )
     @provider = provider.new(@resource)
 
     # Stub all file and config tests

-- 
Puppet packaging for Debian