[Pkg-puppet-devel] Bug#854487: Bug#854487: Bug#854487: Bug#854487: Bug#854487: Binary-only package puppet was silently converted into a package shipping and running a service

[Apollon Oikonomopoulos]

Control: tags -1 pending

On 16:48 Wed 08 Feb     , Apollon Oikonomopoulos wrote:
> On 15:07 Wed 08 Feb     , Apollon Oikonomopoulos wrote:
> > On 19:10 Tue 07 Feb     , Russ Allbery wrote:
> > > For systemd, I think the fix may be as easy as using --no-enable 
> > > in a
> > > dh_systemd_enable override.  I'm not sure how this used to be done for
> > > dh_installinit.
> 
> For dh_installinit things are unfortunately not that straightforward.  
> The only way I can see for this to work, is to call dh_installinit 
> --no-scripts to prevent dh_ii from modifying the maintainer scripts and 
> then manually add most of the boilerplate code without that single 
> `update-rc.d puppet defaults' call. I find this ugly enough to not 
> prefer it over the `puppet agent --disable' approach.

Actually, it is much simpler than that: adding an `update-rc.d defaults 
puppet && update-rc.d disable puppet` before the debhelper stanzas just 
works and does the right thing.

Given that in either case (service disabled, or agent locked) manual 
intervention is required (and desirable), I think it is best to just 
disable the service. I'll prepare an upload shortly.