[Pkg-puppet-devel] Bug#988636: puppet-module-puppetlabs-apache: obsolete package namefor ModSecurity dependency

[Lucas Parsy]

Package: puppet-module-puppetlabs-apache
Version: 3.4.0-1
Severity: important
Tags: patch newcomer

Dear Maintainer,

configuring the ModSecurity module with the Apache puppet module fails,
as the Debian package dependency for this module changed name and was not updated here.

reproduction:
create a `test_modsec.pp` file with this configuration:

```
class test_modsec () {
  unless defined(Class['apache']){
    class { 'apache':
      default_vhost     => false,
    }
  }

 class { 'apache::mod::security':
    modsec_secruleengine => "DetectionOnly" #"On"
  }
}

node default {
  include test_modsec
}
```

and running `sudo puppet apply test_modsec.pp` skips ModSecurity configuration, returning this error (scroll up, in red):
```
Error: Execution of '/usr/bin/apt-get -q -y -o DPkg::Options::=--force-confold install libapache2-modsecurity' returned 100: Reading package lists...
```

this because the package `libapache2-modsecurity` was renamed `libapache2-mod-security2`.

This fix was added in the 'testing' and 'unstable' branches, but not on 'stable'.

Here is a patch that fixes this problem:
```
update mod security package nameIndex: puppet-module-puppetlabs-apache-3.4.0/manifests/params.pp
===================================================================
--- puppet-module-puppetlabs-apache-3.4.0.orig/manifests/params.pp
+++ puppet-module-puppetlabs-apache-3.4.0/manifests/params.pp
@@ -257,7 +257,7 @@ class apache::params inherits ::apache::
         'proxy_html'            => 'libapache2-mod-proxy-html',
         'python'                => 'libapache2-mod-python',
         'rpaf'                  => 'libapache2-mod-rpaf',
-        'security'              => 'libapache2-modsecurity',
+        'security'              => 'libapache2-mod-security2',
         'shib2'                 => 'libapache2-mod-shib2',
         'suphp'                 => 'libapache2-mod-suphp',
         'wsgi'                  => 'libapache2-mod-wsgi',
@@ -285,7 +285,7 @@ class apache::params inherits ::apache::
         'phpXXX'                => 'libapache2-mod-phpXXX',
         'python'                => 'libapache2-mod-python',
         'rpaf'                  => 'libapache2-mod-rpaf',
-        'security'              => 'libapache2-modsecurity',
+        'security'              => 'libapache2-mod-security2',
         'shib2'                 => 'libapache2-mod-shib2',
         'suphp'                 => 'libapache2-mod-suphp',
         'wsgi'                  => 'libapache2-mod-wsgi',
```

Thank you for your time  and sorry if this report is not properly formatted,
I am new to Debian bug report.


-- System Information:
Debian Release: 10.9
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.19.0-16-amd64 (SMP w/1 CPU core)
Kernel taint flags: TAINT_CRAP
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8), LANGUAGE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages puppet-module-puppetlabs-apache depends on:
ii  puppet                           5.5.10-4
ii  puppet-module-puppetlabs-concat  5.1.0-1
ii  puppet-module-puppetlabs-stdlib  5.0.0-1

puppet-module-puppetlabs-apache recommends no packages.

puppet-module-puppetlabs-apache suggests no packages.

-- no debconf information
-------------- next part --------------
update mod security package nameIndex: puppet-module-puppetlabs-apache-3.4.0/manifests/params.pp
===================================================================
--- puppet-module-puppetlabs-apache-3.4.0.orig/manifests/params.pp
+++ puppet-module-puppetlabs-apache-3.4.0/manifests/params.pp
@@ -257,7 +257,7 @@ class apache::params inherits ::apache::
         'proxy_html'            => 'libapache2-mod-proxy-html',
         'python'                => 'libapache2-mod-python',
         'rpaf'                  => 'libapache2-mod-rpaf',
-        'security'              => 'libapache2-modsecurity',
+        'security'              => 'libapache2-mod-security2',
         'shib2'                 => 'libapache2-mod-shib2',
         'suphp'                 => 'libapache2-mod-suphp',
         'wsgi'                  => 'libapache2-mod-wsgi',
@@ -285,7 +285,7 @@ class apache::params inherits ::apache::
         'phpXXX'                => 'libapache2-mod-phpXXX',
         'python'                => 'libapache2-mod-python',
         'rpaf'                  => 'libapache2-mod-rpaf',
-        'security'              => 'libapache2-modsecurity',
+        'security'              => 'libapache2-mod-security2',
         'shib2'                 => 'libapache2-mod-shib2',
         'suphp'                 => 'libapache2-mod-suphp',
         'wsgi'                  => 'libapache2-mod-wsgi',
-------------- next part --------------
update mod security package nameIndex: puppet-module-puppetlabs-apache-3.4.0/manifests/params.pp
===================================================================
--- puppet-module-puppetlabs-apache-3.4.0.orig/manifests/params.pp
+++ puppet-module-puppetlabs-apache-3.4.0/manifests/params.pp
@@ -257,7 +257,7 @@ class apache::params inherits ::apache::
         'proxy_html'            => 'libapache2-mod-proxy-html',
         'python'                => 'libapache2-mod-python',
         'rpaf'                  => 'libapache2-mod-rpaf',
-        'security'              => 'libapache2-modsecurity',
+        'security'              => 'libapache2-mod-security2',
         'shib2'                 => 'libapache2-mod-shib2',
         'suphp'                 => 'libapache2-mod-suphp',
         'wsgi'                  => 'libapache2-mod-wsgi',
@@ -285,7 +285,7 @@ class apache::params inherits ::apache::
         'phpXXX'                => 'libapache2-mod-phpXXX',
         'python'                => 'libapache2-mod-python',
         'rpaf'                  => 'libapache2-mod-rpaf',
-        'security'              => 'libapache2-modsecurity',
+        'security'              => 'libapache2-mod-security2',
         'shib2'                 => 'libapache2-mod-shib2',
         'suphp'                 => 'libapache2-mod-suphp',
         'wsgi'                  => 'libapache2-mod-wsgi',