[PATCH] Remove some unused imports.

John Wright jsw at debian.org
Sun Mar 14 05:34:09 UTC 2010


Hi Jelmer,

On Fri, Mar 12, 2010 at 06:09:32PM +0100, Jelmer Vernooij wrote:
> Hi!
>
> Please find attached two trivial (git-am-style) patches for python-debian.
>
>  * remove some unused imports in python-debian
>  * fix the executability of a test, without which the testsuite files  
> for me

Thanks for the patches; I've applied both.

I had to tweak both patches, though...  bzr seemed to add an extra space
at the end of the changed file lines, so instead of
  "--- a/path/to/file.py\n"
it has
  "--- a/path/to/file.py \n"
which confused git-am.  (Likewise with the "+++" lines.)  Interestingly
enough, patch itself didn't care.  I think git's behavior in this
respect is to consistently support files with spaces in their names, but
it could just be that git-am is too picky. :)

The problem with the other patch was how it specified the file modes.  I
had to change

old file mode 100644
new file mode 100755

to

old mode 100644
new mode 100755

Other than that, the patches worked fine.  Interoperating between
revision control systems is a pain - but you knew that already. ;)

-- 
John Wright <jsw at debian.org>



More information about the pkg-python-debian-maint mailing list