[PATCH] Remove some unused imports.

Jelmer Vernooij jelmer at debian.org
Sun Mar 14 18:44:51 UTC 2010


Hi John,

On 03/14/10 06:34, John Wright wrote:
> Hi Jelmer,
>
> On Fri, Mar 12, 2010 at 06:09:32PM +0100, Jelmer Vernooij wrote:
>    
>> Please find attached two trivial (git-am-style) patches for python-debian.
>>
>>   * remove some unused imports in python-debian
>>   * fix the executability of a test, without which the testsuite files
>> for me
>>      
> Thanks for the patches; I've applied both.
>    
Thanks!
> I had to tweak both patches, though...  bzr seemed to add an extra space
> at the end of the changed file lines, so instead of
>    "--- a/path/to/file.py\n"
> it has
>    "--- a/path/to/file.py \n"
> which confused git-am.  (Likewise with the "+++" lines.)  Interestingly
> enough, patch itself didn't care.  I think git's behavior in this
> respect is to consistently support files with spaces in their names, but
> it could just be that git-am is too picky. :)
>    
It seems like there's usually a date after the filename, separated by a 
space. Python's difflib always writes the space, even if there is no 
date specified.
> The problem with the other patch was how it specified the file modes.  I
> had to change
>
> old file mode 100644
> new file mode 100755
>
> to
>
> old mode 100644
> new mode 100755
>
> Other than that, the patches worked fine.  Interoperating between
> revision control systems is a pain - but you knew that already. ;)
>    
Thanks for reporting these problems in so much detail. I've fixed both 
in bzr-git/dulwich trunk.

Cheers,

Jelmer



More information about the pkg-python-debian-maint mailing list