Bug#1029727: python-debian: please depend on zstd

[Gianfranco Costamagna]

Source: python-debian
Version: 0.1.49


Hello, I see dh-cmake FTBFS in Ubuntu due to this:

test_run_debian_rules (dhcmake.tests.cmake.DHCMakeTestCase.test_run_debian_rules) ... ok
test_autopep8 (dhcmake.tests.source_check.SourceCheckTestCase.test_autopep8) ... ok
test_pyflakes (dhcmake.tests.source_check.SourceCheckTestCase.test_pyflakes) ... ok

======================================================================
ERROR: test_run_debian_rules (dhcmake.tests.cpack.DHCPackTestCase.test_run_debian_rules)
----------------------------------------------------------------------
Traceback (most recent call last):
   File "/usr/lib/python3/dist-packages/debian/debfile.py", line 121, in _custom_decompress
     proc = subprocess.Popen(
            ^^^^^^^^^^^^^^^^^
   File "/usr/lib/python3.11/subprocess.py", line 1024, in __init__
     self._execute_child(args, executable, preexec_fn, close_fds,
   File "/usr/lib/python3.11/subprocess.py", line 1901, in _execute_child
     raise child_exception_type(errno_num, err_msg, err_filename)
FileNotFoundError: [Errno 2] No such file or directory: 'unzstd'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
   File "/<<PKGBUILDDIR>>/dhcmake/tests/cpack.py", line 200, in test_run_debian_rules
     packages = deb822.Packages(f.debcontrol())
                                ^^^^^^^^^^^^^^
   File "/usr/lib/python3/dist-packages/debian/debfile.py", line 493, in debcontrol
     return self.control.debcontrol()
            ^^^^^^^^^^^^^^^^^^^^^^^^^
   File "/usr/lib/python3/dist-packages/debian/debfile.py", line 367, in debcontrol
     return Deb822(self.get_content(CONTROL_FILE))
                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   File "/usr/lib/python3/dist-packages/debian/debfile.py", line 308, in get_content
     f = self.get_file(
         ^^^^^^^^^^^^^^
   File "/usr/lib/python3/dist-packages/debian/debfile.py", line 260, in get_file
     fobj = self.tgz().extractfile(fname)
            ^^^^^^^^^^
   File "/usr/lib/python3/dist-packages/debian/debfile.py", line 146, in tgz
     buffer = _custom_decompress(['unzstd', '--stdout'])
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   File "/usr/lib/python3/dist-packages/debian/debfile.py", line 129, in _custom_decompress
     raise DebError("error while running command '%s' as subprocess: '%s'" %
debian.debfile.DebError: error while running command 'unzstd --stdout' as subprocess: '[Errno 2] No such file or directory: 'unzstd''

----------------------------------------------------------------------
Ran 106 tests in 53.421s

FAILED (errors=1)
Test failed: <unittest.runner.TextTestResult run=106 errors=1 failures=0>
error: Test failed: <unittest.runner.TextTestResult run=106 errors=1 failures=0>
E: pybuild pybuild:388: test: plugin distutils failed with: exit code=1: python3.11 setup.py test
dh_auto_test: error: pybuild --test -i python{version} -p "3.10 3.11" returned exit code 13
make: *** [debian/rules:6: binary] Error 25
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2
--------------------------------------------------------------------------------


I think this can be fixed by depending instead of recommending zstd.

What do you think?

thanks,

Gianfranco
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 840 bytes
Desc: OpenPGP digital signature
URL: <http://alioth-lists.debian.net/pipermail/pkg-python-debian-maint/attachments/20230126/6716ab7a/attachment.sig>