Bug#1029727: python-debian: please depend on zstd

[Jelmer Vernooij]

On Thu, Jan 26, 2023 at 07:49:28PM +0100, Gianfranco Costamagna wrote:
> Hello, I see dh-cmake FTBFS in Ubuntu due to this:
> 
> test_run_debian_rules (dhcmake.tests.cmake.DHCMakeTestCase.test_run_debian_rules) ... ok
> test_autopep8 (dhcmake.tests.source_check.SourceCheckTestCase.test_autopep8) ... ok
> test_pyflakes (dhcmake.tests.source_check.SourceCheckTestCase.test_pyflakes) ... ok
> 
> ======================================================================
> ERROR: test_run_debian_rules (dhcmake.tests.cpack.DHCPackTestCase.test_run_debian_rules)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
>   File "/usr/lib/python3/dist-packages/debian/debfile.py", line 121, in _custom_decompress
>     proc = subprocess.Popen(
>            ^^^^^^^^^^^^^^^^^
>   File "/usr/lib/python3.11/subprocess.py", line 1024, in __init__
>     self._execute_child(args, executable, preexec_fn, close_fds,
>   File "/usr/lib/python3.11/subprocess.py", line 1901, in _execute_child
>     raise child_exception_type(errno_num, err_msg, err_filename)
> FileNotFoundError: [Errno 2] No such file or directory: 'unzstd'
> 
> During handling of the above exception, another exception occurred:
> 
> Traceback (most recent call last):
>   File "/<<PKGBUILDDIR>>/dhcmake/tests/cpack.py", line 200, in test_run_debian_rules
>     packages = deb822.Packages(f.debcontrol())
>                                ^^^^^^^^^^^^^^
>   File "/usr/lib/python3/dist-packages/debian/debfile.py", line 493, in debcontrol
>     return self.control.debcontrol()
>            ^^^^^^^^^^^^^^^^^^^^^^^^^
>   File "/usr/lib/python3/dist-packages/debian/debfile.py", line 367, in debcontrol
>     return Deb822(self.get_content(CONTROL_FILE))
>                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>   File "/usr/lib/python3/dist-packages/debian/debfile.py", line 308, in get_content
>     f = self.get_file(
>         ^^^^^^^^^^^^^^
>   File "/usr/lib/python3/dist-packages/debian/debfile.py", line 260, in get_file
>     fobj = self.tgz().extractfile(fname)
>            ^^^^^^^^^^
>   File "/usr/lib/python3/dist-packages/debian/debfile.py", line 146, in tgz
>     buffer = _custom_decompress(['unzstd', '--stdout'])
>              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>   File "/usr/lib/python3/dist-packages/debian/debfile.py", line 129, in _custom_decompress
>     raise DebError("error while running command '%s' as subprocess: '%s'" %
> debian.debfile.DebError: error while running command 'unzstd --stdout' as subprocess: '[Errno 2] No such file or directory: 'unzstd''

python3-debian has zstd as a Recommends since it work fine without it
and with any package found in Debian. The ch-cmake tests pass fine here without zstd installed.

On Ubuntu, I believe zstd compression is the default, so it might make
sense for Ubuntu to move zstd from Recommends to Depends.

Cheers,

Jelmer