[request-tracker-maintainers] RT 5.0 - git repo

[Andrew Ruthven]

On Sat, 2020-11-28 at 13:03 +0000, Dominic Hargreaves wrote:
> On Fri, Nov 27, 2020 at 11:13:52PM +1300, Andrew Ruthven wrote:
> > Hey,
> > 
> > I've pushed my changes for RT 5.0 to the master-5 branch, there are
> > some interesting warnings from lintian:

Issue raised with BPS with the missing/mismatched source as suggested.

> 
> > E: request-tracker5 source: source-is-missing
> > share/static/RichText/skins/bootstrapck/sample/js/jquery-
> > 1.11.0.min.js
> 
> This looks like an unused example file, I think we should repack
> the source to remove this whole sample/ folder.

> (Or, since it looks like we'll need to ask upstream for some changes
> anyway, ask them to remove it in their distribution).

Should these files be removed upstream? I'm deleting them in the
generated .debs as they aren't required, and those samples also include
tracking javascript.

> > E: request-tracker5 source: source-is-missing
> > share/static/js/Chart.min.js
> > E: request-tracker5 source: source-is-missing
> > share/static/js/bootstrap-select.min.js
> > E: request-tracker5 source: source-is-missing
> > share/static/js/bootstrap.min.js
> > E: request-tracker5 source: source-is-missing
> > share/static/js/chartjs-
> > plugin-colorschemes.min.js
> 
> These look like Lintian getting it wrong - the sources look present
> in third-party-source/dev/third-party/.

Aye.

> > E: request-tracker5 source: source-is-missing 
> > share/static/js/fontawesome.min.js
> 
> third-party-source/devel/third-party/fontawesome looks incomplete.

They specify various npm commands to download them, I asked for the
actual source to be included.

> > E: request-tracker5 source: source-is-missing 
> > share/static/js/jquery.jgrowl.min.js
> > E: request-tracker5 source: source-is-missing
> > share/static/js/popper.min.js
> 
> These look like Lintian getting it wrong - the sources look present
> in third-party-source/dev/third-party/.   

Ack.

> > E: request-tracker5 source: source-is-missing 
> > share/static/js/selectize.min.js
> 
> third-party-source/devel/third-party/selectize.js looks like
> completely
> the wrong file.

Looks like they've changed the comment in the header?

> 
> Ah, okay, you're trying to override the errors above but that's not
> working. It looks like the '*' should no longer be included.

I tried both with and without the '*'...

> But at least some of the comments above need addressing with
> upstream.

Ack.

Cheers,
Andrew

-- 
Andrew Ruthven, Wellington, New Zealand
andrew at etc.gen.nz              |
Catalyst Cloud:  | This space intentionally left blank
https://catalystcloud.nz |