[Pkg-roundcube-maintainers] Bug#788448: roundcube{, -plugins}: copyright file missing after upgrade (policy 12.5)

[Andreas Beckmann]

Package: roundcube,roundcube-plugins
Version: 1.1.1+dfsg.1-2
Severity: serious
User: debian-qa at lists.debian.org
Usertags: piuparts

Hi,

a test with piuparts revealed that your package misses the copyright
file after an upgrade, which is a violation of Policy 12.5:
https://www.debian.org/doc/debian-policy/ch-docs.html#s-copyrightfile

After the upgrade /usr/share/doc/$PACKAGE/ is just an empty directory.

This was observed on the following upgrade paths:

  testing -> sid

>From the attached log (scroll to the bottom...):

  MISSING COPYRIGHT FILE: /usr/share/doc/roundcube/copyright
  # ls -lad /usr/share/doc/roundcube
  drwxr-xr-x 2 root root 40 May  5 15:34 /usr/share/doc/roundcube
  # ls -la /usr/share/doc/roundcube/
  total 0
  drwxr-xr-x   2 root root   40 May  5 15:34 .
  drwxr-xr-x 165 root root 3600 May  5 15:34 ..

  MISSING COPYRIGHT FILE: /usr/share/doc/roundcube-plugins/copyright
  # ls -lad /usr/share/doc/roundcube-plugins
  drwxr-xr-x 2 root root 40 May  5 15:30 /usr/share/doc/roundcube-plugins
  # ls -la /usr/share/doc/roundcube-plugins/
  total 0
  drwxr-xr-x   2 root root   40 May  5 15:30 .
  drwxr-xr-x 165 root root 3600 May  5 15:30 ..


Additional info may be available here:
https://wiki.debian.org/MissingCopyrightFile

Note that dpkg intentionally does not replace directories with symlinks
and vice versa, you need the maintainer scripts to do this.
See in particular the end of point 4 in
https://www.debian.org/doc/debian-policy/ch-maintainerscripts.html#s-unpackphase

It is recommended to use the dpkg-maintscript-helper commands
'dir_to_symlink' and 'symlink_to_dir' (available since dpkg 1.17.14)
to perform the conversion, ideally using d/$PACKAGE.mainstscript.
Do not forget to add 'Pre-Depends: ${misc:Pre-Depends}' in d/control.
See dpkg-maintscript-helper(1) and dh_installdeb(1) for details.


cheers,

Andreas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: roundcube_1.1.1+dfsg.1-2.log.gz
Type: application/gzip
Size: 28461 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-roundcube-maintainers/attachments/20150611/c9b26ef1/attachment-0001.bin>