[Pkg-roundcube-maintainers] Bug#978073: Bug#978073: src:roundcube: closure-compiler and yui-compressor are of questionable quality

[Guilhem Moulin]

Control: clone -1 -2
Control: tag -1 upstream
Control: retitle -2 Please ship precompressed JS and CSS files
Control: severity -1 normal
Control: severity -2 wishlist

On Fri, 25 Dec 2020 at 14:55:00 +0100, Jonas Smedegaard wrote:
> Build routines use the compressors closure-compiler and yui-compressor,
> not because upstream is tightly integrated with those but as deviation
> with Debian.

Upstream does use closure-compiler and yui-compressor for their builds,
and while this remains the case I'm quite reluctant to switch to any
else.  FWIW, we used to use yui compressor for JS also but with 1.4 it
started generating bogus output from the upstream JS sources; that's
when I decided to align on upstream's tooling.  If upstream updates
their tooling we'll update ours accordingly.

> In addition to compressing the code _structure_, I recommend to also
> install JavaScript and CSS files precompressed with gzip and brotli.
> 
> I propose to look at the debian/rules rile in the source package
> libjs-sdp for a compact way to handle that.  Specifically the "%.gz"
> target, having target "override_dh_auto_build" depend on all *.gz files,
> and the final magic target ".SECONDARY:".

Better track that in separate (wishlist) bug #-2.
 
> To use that approach you will need to restructure to (generate CSS and)
> compress files in separate targets instead of in the install target,
> which in my opinion ought to be corrected anyway: it really is build
> rules, not install rules!

Ack and agreed, will get to this now.

-- 
Guilhem.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-roundcube-maintainers/attachments/20201225/b2fef988/attachment-0001.sig>