[Pkg-roundcube-maintainers] Cleanup roundcube

[Sandro Knauß]

On Mittwoch, 27. Januar 2021 13:11:14 CET Guilhem Moulin wrote:
> Hi Sandro!
> 
> On Wed, 27 Jan 2021 at 03:42:48 +0100, Sandro Knauß wrote:
> > after some month I found time again to look at the roundcube package and I
> > have no glue at all what have changed.
> 
> Does d/changelog, `git log` and/or `git blame` shed some light on this? :-)

I must say I did not invest much time into it to understand it. 
 
> > Should I do a release or are there any planed changes from your side in
> > the
> > pipeline?
> 
> I plan to do one more before the freeze to clarify the status with PHP8.
> (Was hoping to unbundle publickey-XXX.js and some more fonts as well, but
> that might be tight now.)

Okay than you take over again. great.

> > * copy of install-jsdeps.sh inside debian folder. As I marked in the
> > header
> > once, it can be replaced with the version shipped from roundcube > 1.3.0.
> > But I think it is not used anymore anyways. So we can remove it?
> 
> Hmm, I vaguely recall trying to get rid of it when working on packaging
> 1.4 RC, and that it had to be preserved for the download phase (while
> d/rules doesn't mention it, debian/missing-sources/README still does).
> Tried again now and it works like a charm with `bin/install-jsdeps.sh`
> (with patches applied of course).  Not sure what if I had the wrong
> assessment in 2019, or if something changed meanwhile.  Anyway fixed in
> 8306e105f, thanks!

cool, thanks.

> > * the d/rules looks quite complicated
> 
> Most of this complexity was introduced my me some weeks ago in eb4d202fe :-)
> I didn't like the previous one
> 
>    
> https://sources.debian.org/src/roundcube/1.3.16+dfsg.1-1%7Edeb10u1/debian/r
> ules/
> 
> with install rules mixed with build rules as Jonas Smedegaard rightfully
> pointed out in #978075.  Moreover using for loops and/or `find | xargs`
> prevent parallel execution and it's cumbersome to get error checking
> right.

yes this I can fully understand, that a mixed rules is not not right. And if 
this style make it easier for you to find an fix issues, fine.

> > aren't there things that should better been part of debhelper (some
> > buildsystem etc.) I normally do KDE packages these days and there the
> > rules file just have two or three lines ;) But it is not obvious what
> > different parts can be bundled, so other packages also can profit from
> > this work.
> > 
> > * a lot of d/rules section can be moved to execute_after_dh_XXX (when it
> > is
> > fine to use debhelper 13 also in backports)
> 
> I'm not sure which example you had in mind here, but if upstream had a
> proper Makefile our d/rules would also become much simpler too :-)

well maybe, than it is worth to discuss with upstream, if they would take over 
some parts. so our plate gets smaller.

> AFAICT the complex stuff is the build system, so what runs *before*
> dh_auto_build.  Maybe that part should best be shipped in the form of an
> upstream Makefile, even though it might require tweaking as we for
> instance generate configuration stubs in plugins/*/config.inc.php.dist.
> I don't mind splitting d/rules into d/Makefile.roundcube and d/rules,
> but I'm quite keen to keep a build system that makes use of the Makefile
> dependency graph as it gives error checking and parallelism for free:
> that was the essence of the recent eb4d202fe.  I'd also argue that
> compared to d/*.install, using Makefile directives at dh_install* gives
> more flexibility when a new plugin or skin is added; this even avoids
> bugs reports such as #958642.

It is not about splitting d/rules into two parts, if they both would still be 
only in debian subdir, we do not win anything. I was more looking forward to 
bring stuff upstream either to general Debian packages or at roundcube 
directly. Specially if you say most of the part is pre build stuff upstream may 
be interested too.

With debhelper 13: you are able to replace:

override_dh_fixperms:
   dh_fixperms --
   [...]

with:

execulate_after_dh_fixperms:
  [...]

in this manner you can replace 
override_dh_fixperms, override_dh_install, override_dh_auto_clean, 
override_dh_link 

see "man dh" and search for execute_after_dh_fixperms

hefee
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <http://alioth-lists.debian.net/pipermail/pkg-roundcube-maintainers/attachments/20210129/63fa87a1/attachment.sig>