[Pkg-roundcube-maintainers] Bug#1048513: roundcube-skin-classic: Fails to build source after successful build

[Lucas Nussbaum]

Source: roundcube-skin-classic
Version: 1.6.0+ds-2
Severity: minor
Tags: trixie sid ftbfs
User: lucas at debian.org
Usertags: ftbfs-sab-20230813 ftbfs-source-after-build
User: debian-qa at lists.debian.org
Usertags: qa-doublebuild

Hi,

This package fails to build a source package after a successful build
(dpkg-buildpackage ; dpkg-buildpackage -S).

This is probably a clear violation of Debian Policy section 4.9 (clean target),
but this is filed as severity:minor for now, because a discussion on
debian-devel showed that we might want to revisit the requirement of a working
'clean' target.

More information about this class of issues, included common problems and
solutions, is available at
https://wiki.debian.org/qa.debian.org/FTBFS/SourceAfterBuild

Relevant part of the build log:
> cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S
> ------------------------------------------------------------------------------------------------------------------------------------------------------
> 
> dpkg-buildpackage: info: source package roundcube-skin-classic
> dpkg-buildpackage: info: source version 1.6.0+ds-2
> dpkg-buildpackage: info: source distribution unstable
> dpkg-buildpackage: info: source changed by Guilhem Moulin <guilhem at debian.org>
>  dpkg-source --before-build .
>  debian/rules clean
> dh clean
>    debian/rules execute_after_dh_auto_clean
> make[1]: Entering directory '/<<PKGBUILDDIR>>'
> make[1]: Leaving directory '/<<PKGBUILDDIR>>'
>    dh_clean
>  dpkg-source -b .
> dpkg-source: info: using source format '3.0 (quilt)'
> dpkg-source: info: building roundcube-skin-classic using existing ./roundcube-skin-classic_1.6.0+ds.orig.tar.gz
> dpkg-source: info: using patch list from debian/patches/series
> dpkg-source: info: local changes detected, the modified files are:
>  roundcube-skin-classic-1.6.0+ds/addressbook.css
>  roundcube-skin-classic-1.6.0+ds/common.css
>  roundcube-skin-classic-1.6.0+ds/embed.css
>  roundcube-skin-classic-1.6.0+ds/googiespell.css
>  roundcube-skin-classic-1.6.0+ds/mail.css
>  roundcube-skin-classic-1.6.0+ds/plugins/acl/acl.css
>  roundcube-skin-classic-1.6.0+ds/plugins/archive/archive.css
>  roundcube-skin-classic-1.6.0+ds/plugins/enigma/enigma.css
>  roundcube-skin-classic-1.6.0+ds/plugins/help/help.css
>  roundcube-skin-classic-1.6.0+ds/plugins/jqueryui/jquery-ui.css
>  roundcube-skin-classic-1.6.0+ds/plugins/managesieve/managesieve.css
>  roundcube-skin-classic-1.6.0+ds/plugins/managesieve/managesieve_mail.css
>  roundcube-skin-classic-1.6.0+ds/plugins/markasjunk/markasjunk.css
>  roundcube-skin-classic-1.6.0+ds/plugins/vcard_attachments/style.css
>  roundcube-skin-classic-1.6.0+ds/plugins/zipdownload/zipdownload.css
>  roundcube-skin-classic-1.6.0+ds/settings.css
> dpkg-source: error: aborting due to unexpected upstream changes, see /tmp/roundcube-skin-classic_1.6.0+ds-2.diff.p66Ttq
> dpkg-source: info: Hint: make sure the version in debian/changelog matches the unpacked source tree
> dpkg-source: info: you can integrate the local changes with dpkg-source --commit
> dpkg-buildpackage: error: dpkg-source -b . subprocess returned exit status 2
> 
> E: Command 'cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S' failed to run.


The full build log is available from:
http://qa-logs.debian.net/2023/08/13/roundcube-skin-classic_1.6.0+ds-2_unstable.log

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.