[DRE-maint] RFS: libglobalhotkeys-ruby

vincent carmona vinc4mai at gmail.com
Wed Aug 4 18:24:55 UTC 2010


2010/8/4 vincent carmona <vinc4mai at gmail.com>:
> 2010/8/4, Lucas Nussbaum <lucas at lucas-nussbaum.net>:
>> Hi,
>>
>> Quick review:
>> - use english for commit messages :-)
>> - changelog: UNRELEASED -> unstable
>> - you should have a libglobalhotkeys-ruby1.8 that contains the actual
>>   files, as well as a libglobalhotkeys-ruby package that simply depends
>>   on libglobalhotkeys-ruby (see the other packages in the repo)
>> - no '.' at end of Description's first line.
>> - use sentences in long description.
>> - in rules, use the cdbs classes provided by the team, not the default
>>   debhelper template (see other packages)
>> - your library is loaded using require 'rghk', so I think that it makes
>>   more sense to name the package librghk-ruby.
>>
>>> I still have two lintian infos :
>>> description-synopsis-might-not-be-phrased-properly
>>> possible-documentation-but-no-doc-base-registration
>>>
>>> Do you think I should rephrase the description or use doc-base ?
>>
>> Yes, probably both.
>> --
>> | Lucas Nussbaum
>> | lucas at lucas-nussbaum.net   http://www.lucas-nussbaum.net/ |
>> | jabber: lucas at nussbaum.fr             GPG: 1024D/023B3F4F |
>>
>
> Hi Lucas.
>
> Thanks for your review.
> I will take a look at cdbs and doc-base which I do not know.
> I will let you know when I have done taking acount of your remarks.
>
> Sorry for the french commit message :(. I had to be sleepy when I made it.
>
> Vincent Carmona
>

Hi.

I now use cdbs. I provide libglobalhotkeys-ruby1.8 and libglobalhotkeys-ruby.

If I rename the package librghk, do I need to commit my change under
libglobalhotkeys directories or use svn-inject to create a new
directory ? Then how I delete the old one ?
libglobalhotkeys-ruby seems more  understandable than librghk-ruby.

As for doc-base, the package does not install "online" documentation,
only the rdoc html file and a ruby example. Should I use doc-base ?

Vincent Carmona



More information about the Pkg-ruby-extras-maintainers mailing list