[DRE-maint] ruby-pg-query_1.3.0-1_amd64.changes REJECTED

[Pirate Praveen]

On Sun, Mar 21, 2021 at 11:24 pm, Pirate Praveen 
<praveen at onenetbeyond.org> wrote:
> 
> 
> On 2021, മാർച്ച് 21 2:30:08 AM IST, Sean Whitton 
> <ftpmaster at ftp-master.debian.org> wrote:
>> 
>> +----------------------+
>> |   REJECT reasoning   |
>> +----------------------+
>> 
>> At least the following files have different copyright 
>> holders/licenses:
>> src_port_qsort.c contrib_pgcrypto_sha1.c sha1.h src_port_erand48.c
> 
> I have fixed the copyright notices in git and will upload once I can 
> find an answer to the comment below.
> 

I have uploaded again with the missing copyright notices added.

>> +----------------------+
>> |    Other comments    |
>> +----------------------+
>> 
>> A huge amount of uncompiled source code is installed into /usr/lib;
>> shouldn't it be in /usr/share, and installed arch:all?
> 
> These are used during build. Its upstream build system downloads 
> these sources during build. I have patched its build system to use 
> the sources provided as extra tarball. I had to include these files 
> in list of files in gemspec for the build to find these files. I will 
> need help from ruby team to exclude these in the binary package.
> 
> At least right now, the default is to include all files belonging to 
> a gem in a single directory, either arch specific directory or arch 
> independent directory. I don't think we can mix directories for same 
> gem.
> 
> Ruby team, any ideas on the best method here? If we don't add it to 
> gemspec's list of files, it won't build and if we remove the files in 
> deb, we will have a broken gemspec file.
> 

Can you accept the package and file a bug with appropriate severity so 
we can tackle this later? We could not yet find a good way to solve 
this and I don't think it is worthy of a reject.

>> +----------------------+
>> |         N.B.         |
>> +----------------------+
>> 
>> This review may not be exhaustive.  Please check your source package
>> against your d/copyright and the ftpmaster REJECT-FAQ, throughly,
>> before uploading to NEW again.
>> 
>> Thank you for your time and contribution!
>> 
>> Sean
>> 
>> 
>> 
>> ===
>> 
>> Please feel free to respond to this email if you don't understand why
>> your files were rejected, or if you upload new files which address 
>> our
>> concerns.
>> 
> 
> --
> Sent from my Android device with K-9 Mail. Please excuse my brevity.