[DRE-maint] Bug#1136604: vagrant uses pidof but does not depend on procps

[Gioele Barabucci]

Source: vagrant
Version: 2.3.7+git20230731.5fc64cde+dfsg-4
Usertags: pidof-without-procps

Dear maintainer(s) of vagrant,

it appears that vagrant uses `pidof` in its testsuite, or that
at least one of its binary packages uses `pidof` at runtime.
Historically, `pidof` was provided by the Essential package
`sysvinit-tools`, making an explicit dependency unnecessary. However
`pidof` will soon be moved to `procps` and will no longer be part of
the Essential set.

Please add an explicit dependency on `procps`:

* via the `Depends:` field of all binary packages of vagrant
  that use `pidof` at runtime;
* via the `Build-Depends:` field of vagrant, if `pidof` is
  used in tests run at build-time;
* via the `Depends:` field of `debian/control/tests`, if `pidof` is
  used in autopkgtests.

To prevent any disruption for users of vagrant, please add
this dependency now, before `pidof` is moved from `sysvinit-utils` to
`procps`. Alternatively, you could remove all uses of `pidof`.

It is believed that vagrant uses `pidof` due to the following
code snippets:

```
path: vagrant_2.3.7+git20230731.5fc64cde+dfsg-4/plugins/hosts/slackware/cap/nfs.rb
      class NFS
        def self.nfs_check_command(env)
          "/sbin/pidof nfsd >/dev/null"
        end
```

Feel free to close this issue if this is a false positive (for example
if this code is in an unreachable code path).

Regards,

-- 
Gioele Barabucci