[Pkg-rust-maintainers] rust-bstr_0.1.3-1_amd64.changes REJECTED

[Sylvestre Ledru]

Le 11/07/2019 à 23:00, Thorsten Alteholz a écrit :
> 
> Hi Sylvestre,
> 
> our hardworking trainees found the following issues in your package:
>   Stated copyright and licensing for src/unicode/data subdir is not
>   correct.
>   
>   We need the 'ucd-generate' tool to be in the archive in order for some
>   *.rs files in src\unicode\fsm\ to be regenerated from their preferred
>   form for modification (see their headers).
The headers explain that they are generated. Not that they have too. ;)
I will upload ucd-generate but I am not sure why it should be a blocker
to have bstr in the archive.


>   Do we have source for src\unicode\fsm\*.dfa ?  And what is their
>   licensing status?
They are generated with this script:
https://github.com/BurntSushi/bstr/blob/master/scripts/generate-unicode-data

>   Copyright years for upstream are not what's actually claimed in the
>   source code (only 2015 is present there).
This is a typo upstream as the project started in 2018:
https://github.com/BurntSushi/bstr/commit/706129ab707f644defe94dd63e3587fa2e58df6a

I submitted a PR upstream:
https://github.com/BurntSushi/bstr/pull/10
and reuploaded a new version with the unicode copyright!

Thanks again,
S