[Pkg-rust-maintainers] Bug#961387: FTBFS due to usage of array::into_iter()

[Logan Rosen]

Source: rust-ring
Version: 0.16.9-3
Severity: serious
Tags: patch ftbfs
Justification: fails to build from source (but built successfully in the past)
User: ubuntu-devel at lists.ubuntu.com
Usertags: origin-ubuntu groovy ubuntu-patch

Hi,

rust-ring currently FTBFS due to usage of array::into_iter() instead of
array::iter(). See build log: https://buildd.debian.org/status/fetch.php?pkg=rust-ring&arch=amd64&ver=0.16.9-3&stamp=1587387625&raw=0

In Ubuntu, the attached patch was applied to achieve the following:

  * d/p/use-array-iter.patch: Cherrypick upstream commit to use array::iter,
    fixing FTBFS.

Thanks for considering the patch.

Logan
-------------- next part --------------
diff -Nru rust-ring-0.16.9/debian/patches/series rust-ring-0.16.9/debian/patches/series
--- rust-ring-0.16.9/debian/patches/series	2020-04-20 08:16:05.000000000 -0400
+++ rust-ring-0.16.9/debian/patches/series	2020-05-23 17:01:04.000000000 -0400
@@ -1,2 +1,3 @@
 relax-deps.patch
 built-using.patch
+use-array-iter.patch
diff -Nru rust-ring-0.16.9/debian/patches/use-array-iter.patch rust-ring-0.16.9/debian/patches/use-array-iter.patch
--- rust-ring-0.16.9/debian/patches/use-array-iter.patch	1969-12-31 19:00:00.000000000 -0500
+++ rust-ring-0.16.9/debian/patches/use-array-iter.patch	2020-05-23 17:00:40.000000000 -0400
@@ -0,0 +1,23 @@
+From c250e3125e2621cbe947e811e3de0fc5fa1904aa Mon Sep 17 00:00:00 2001
+From: lzutao <taolzu at gmail.com>
+Date: Wed, 30 Oct 2019 14:51:17 +0700
+Subject: [PATCH] Use array::iter
+
+See clippy::into_iter lint and https://github.com/rust-lang/rust/pull/65819
+---
+ build.rs | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/build.rs b/build.rs
+index c6cb3a700..f7eded9de 100644
+--- a/build.rs
++++ b/build.rs
+@@ -418,7 +418,7 @@ fn build_c_code(target: &Target, pregenerated: PathBuf, out_dir: &Path) {
+ 
+     // XXX: Ideally, ring-test would only be built for `cargo test`, but Cargo
+     // can't do that yet.
+-    libs.into_iter()
++    libs.iter()
+         .for_each(|&(lib_name, srcs, additional_srcs)| {
+             build_library(
+                 &target,