[Pkg-rust-maintainers] Bug#1078698: Please backport packed/align struct fix from upstream

Faidon Liambotis paravoid at debian.org
Wed Aug 14 13:45:50 BST 2024


Source: rust-bindgen
Version: 0.66.1-7
Severity: normal
Tags: patch upstream

bcachefs(-tools) upstream has been plagued by compilation issues
resulting from a combination of packed/align. This has been discussed in
its mailing list, as well as with both bindgen & Rust upstreams:
https://github.com/rust-lang/rust/issues/59154
https://github.com/rust-lang/rust/issues/33158
https://github.com/rust-lang/rust-bindgen/issues/2240
https://github.com/rust-lang/rust-bindgen/issues/2725
(etc.)

Thomas Bertschinger submitted a few workarounds in the bcachefs-tools
upstream project, but eventually got a better fix in rust-bindgen,
merged upstream and released with 0.69.4:
https://github.com/rust-lang/rust-bindgen/commit/199bee441ad0fb81b4b054e0c1e2ffb51f4e4a6d

src:bcachefs-tools ships a revert of one of those patches to a version
that was kinda working with older bindgen, but this FTBFS on at least
i386 (#1074797).

I suppose updating bindgen to 0.69.4 to Debian is a larger endeavour.

Fortunately though, the aforementioned commit applies cleanly on
src:rust-bindgen 0.66.1-7. The cherry-pick is attached here for your
convenience, ready to be dropped to debian/patches.

With this patch, plus a rebuild of src:rust-bindgen-cli, I've managed to
successfully build bcachefs-tools 1:1.9.4-1~exp1 for both amd64 and
i386, with the "revert-bindgen-changes.patch" patch disabled.

Would it be possible to include this patch in Debian? Thanks in advance!

Regards,
Faidon
-------------- next part --------------
A non-text attachment was scrubbed...
Name: try-to-avoid-repr-packed-when-align-is-needed.patch
Type: text/x-diff
Size: 3974 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-rust-maintainers/attachments/20240814/baa2dd39/attachment.patch>


More information about the Pkg-rust-maintainers mailing list