[Pkg-rust-maintainers] Not embedding jquery

Angus Lees gus at debian.org
Mon Aug 8 06:16:41 UTC 2016


I think your patch also needs a rustdoc run-time dependency on libjs-jquery.
If we're going to remove it from the repacked upstream source, then we can
also remove the un-minified source in debian/missing-sources/

For comparison (slightly different situation), in cargo packaging we just
replaced the symlink after building the docs:
  https://anonscm.debian.org/cgit/pkg-rust/cargo.git/tree/debian/rules#n62

---

Hrm.  I feel like this is a user-visible change, and therefore something we
might not want to do without a good reason.  On the other hand, anyone who
publishes HTML docs to another host *should* be resolving out-of-sub-tree
symlinks anyway.  So I'm still on the fence :/

A possible alternative might be to read the source file from
/usr/share/javascript at generation time (rather than embed it), but still
generate a regular jquery.js output file (ie: copy, not symlink).  Less
space-efficient in output, but makes it look closer to what upstream
generates.

I definitely agree that we should at least build-depend on libjs-jquery and
replace the embedded copy with the libjs-jquery version.  I have a very
vague memory that someone tried this and it wasn't as easy as just dropping
in a (possibly different) version of jquery however - which invalidates all
of the above alternatives.  Anyone remember the details?

 - Gus

On Sat, 6 Aug 2016 at 05:15 Ximin Luo <infinity0 at debian.org> wrote:

> Ximin Luo:
> >
> https://anonscm.debian.org/cgit/pkg-rust/rust.git/commit/?h=_experiment_jquery&id=6b3175c6
>
> Correction, I updated it a bit. URL to the latest version (dynamic):
>
>
> https://anonscm.debian.org/cgit/pkg-rust/rust.git/commit/?h=_experiment_jquery&id=_experiment_jquery
>
> X
>
> --
> GPG: ed25519/56034877E1F87C35
> GPG: rsa4096/1318EFAC5FBBDBCE
> https://github.com/infinity0/pubkeys.git
>
> _______________________________________________
> Pkg-rust-maintainers mailing list
> Pkg-rust-maintainers at lists.alioth.debian.org
> https://lists.alioth.debian.org/mailman/listinfo/pkg-rust-maintainers
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.alioth.debian.org/pipermail/pkg-rust-maintainers/attachments/20160808/c6396035/attachment.html>


More information about the Pkg-rust-maintainers mailing list