[Pkg-salt-team] Uploaded repository - some issues remain

[Andrii Senkovych]

Guys,

I see you are working on new version right now. Since you have quite
intensive dialog, I'd better nor interfere until you are finished. If
there's a possibility, I'd commit some things too, but perhaps I'll
make some package review for now until you are satisfied with your
work.

Fisrt, please look at what you actually commit and don't forget to run
debian/rules clean _before_ committing. Commit 70211f8855a included
the whole build tree together with *.py files, compiled documentation
and other garbage that should not appear in source package as well as
in the repository.

Please use lintian --pedantic to check all warnings.

I have pushed some more changes to a separate branch[1]. You might
want to review them and incorporate into master branch fully or
partially. New changes will appear in that branch as well. Current
lintian output for this branch is:

$ lintian --pedantic salt_0.14.0-1_amd64.changes
P: salt-minion: no-upstream-changelog
P: salt-master: no-upstream-changelog
P: salt-doc: no-upstream-changelog
P: salt-syndic: no-upstream-changelog
P: salt-common: no-upstream-changelog
W: salt-common: manpage-has-errors-from-man
usr/share/man/man7/salt.7.gz 2052: warning [p 22, 4.3i, div `3tbd2,2',
0.0i]: can't break line

Currently I could not fix the manual page. That line corresponds to
the data in the table that is by all logic should not be breakable
into several lines because it's a single token. Maybe we should
suppress this warning.

I'm going to work on the following tasks:
1) Run tests during build.
2) Substitute manual javascript removal with dh_sphinxdoc.
3) Try pybuild

I'll notify you if something new appears. Here are some details:

It is possible to run salt tests during build process, however there
are some tests failing since they run from fakeroot'ed unprivileged
user (build log attached). I believe it is possible to skip these
tests (by applying quilt patch) or ask upstream to fix them. Note:
this would also introduce new build-deps: python-mako and
python-unittest2 for python < 2.7

Maybe you'd like to test against all supported python versions. You
can always detect those with pyversions utility. Here's a snippet that
will enable running tests during package building:

ifeq (,$(filter nocheck,$(DEB_BUILD_OPTIONS)))
override_dh_auto_test:
    python setup.py test
endif

Another thing I've spotted is manual removal of javascript files as
well. I'm not aware if you have tried to use dh_sphinxdoc but you
might want to use it. It's pretty simple:

%:
     dh $@ --wih python2,bash-completion,sphinxdoc

I've already tried building 0.14 with sphinxdoc. Unfortunately it had
failed on a first check of searchindex.js. This can be a bug in dh_
helper, I'll try to contact its developer to fix the issue. Until then
that code can be left with no changes.

Also there's a new (hopefully, the last) helper for building python
projects called pybuild which I'd like to try in a separate branch.

Thanks.

 [1]: http://anonscm.debian.org/gitweb/?p=pkg-salt/pkg-salt.git;a=shortlog;h=refs/heads/proposals
--
Best regards, Andrii Senkovych